Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.8 in AzDo pipelines #10276

Merged
merged 17 commits into from
Feb 27, 2020

Conversation

kimadeline
Copy link

For #8298

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

Merging #10276 into master will decrease coverage by 0.44%.
The diff coverage is 49.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10276      +/-   ##
==========================================
- Coverage   61.27%   60.82%   -0.45%     
==========================================
  Files         570      570              
  Lines       30958    30720     -238     
  Branches     4441     4376      -65     
==========================================
- Hits        18969    18685     -284     
- Misses      11001    11082      +81     
+ Partials      988      953      -35
Impacted Files Coverage Δ
...c/datascience-ui/react-common/settingsReactSide.ts 22.22% <ø> (ø) ⬆️
.../client/testing/nosetest/services/parserService.ts 12.34% <ø> (ø) ⬆️
src/client/testing/pytest/services/argsService.ts 39.21% <ø> (ø) ⬆️
src/client/telemetry/index.ts 87.38% <ø> (ø) ⬆️
src/datascience-ui/react-common/constants.ts 0% <0%> (ø) ⬆️
.../datascience/interactive-common/interactiveBase.ts 5.72% <0%> (-10.92%) ⬇️
...ractive-window/interactiveWindowCommandListener.ts 58.09% <0%> (ø) ⬆️
src/client/datascience/webViewHost.ts 8.78% <0%> (-51.77%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 16.44% <10%> (-0.92%) ⬇️
src/client/common/application/types.ts 100% <100%> (ø) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fc0bd...e382a98. Read the comment docs.

@kimadeline kimadeline closed this Feb 26, 2020
@kimadeline kimadeline reopened this Feb 26, 2020
@kimadeline kimadeline marked this pull request as ready for review February 27, 2020 07:37
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

ericsnowcurrently added a commit that referenced this pull request Mar 3, 2020
(for #10357)

We updated CI to test against 3.8 in #10276. Doing so revealed that some of our Jedi-related tests fail on 3.8, but only on Windows. We're temporarily skipping those tests. The will be fixed in #10399.
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants