typescript.suggestionActions.enabled prevents greying out of unused variables
#50890
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
typescript
Typescript support issues
verified
Verification succeeded
Milestone
Comments
|
I can't repo this:
Any user settings on your side? Other repo steps? |
|
Narrowed it down to Once I have it as |
octref
changed the title
noUnusedLocals toggles both squiggly and colortypescript.suggestionActions.enabled prevents greying out of unused variables
rebornix
added
verified
|
@mjbvz not sure if I did anything wrong while verifying this issue:
Based on what @octref described, it seems unused variables should still be greyed out after step 4. |
|
Actually there is a bug for updating grayed out vars if you reload the workspace with suggestions disabled. Will push a fix for that |
mjbvz
added a commit
that referenced
this issue
Jun 1, 2018
|
Just checked with @RMacfarlane. This is the problem I mentioned before where toggling the settings resets colorization. Editing the document or reloading the document gets things grayed out again Not worth fix since this setting is only one many people are using |
RMacfarlane
added
verified
sbatten
pushed a commit
to sbatten/vscode
that referenced
this issue
Jun 4, 2018
* Merge NPM Scripts: Added configuration option to change default click action microsoft#49282 * fix microsoft#50560 * Fix getmac test (microsoft#48804) * Cleaning up some typos in vscode.d.ts and vscode.proposed.d.ts (microsoft#50533) * yarn.lock changes * grid - log serialized state if restoring failed * Fixes microsoft#50382: Align .mtku with .detected-link * debug issues back to isidorn * Hide interactive playground commands from command palette (fixes microsoft#49706) * grid - drop outline as focus indication and rely on dimmed state * grid - allow to close empty group when closing all editors of a group * grid - get preferredSize from grid * Fixes microsoft#43003: Cannot specify a global problemMatcher in tasks.json * cleanup integrated terminal support for debugging * grid - action wording tweaks * microsoft#45663 Use core translations asset * grid - allow to close dirty diff editor if master is still opened in same group * Support to run npm install from a package node * grid - log previous UI state upon error * grid - stronger border top color otherwise when a tab is showing in a vertical split, the border collides with the sash border * remove todo * do not append logLevel microsoft#47774 * Implement Go To Next/Previous Breakpoint editor actions * Include enabledOnly in debug model interface * remove from schema microsoft#47774 * microsoft#45663 fix compilations * change openBreakpointSource to use IBreakpoint * return passed context if resourceOrContext is not useful * fix off by one issue * Simplify implementation * return context if it has a groupId * polish * Fixes microsoft/monaco-editor#891: Focus editor when returning from context menu * go to next / previosu breakpoint minor polish * Add Endgame for 1.24 * fix index computing for editor close case * Fix microsoft#49145 - Enable/Disable viewlets by views when context - Move viewlet enablement/disablement to views service - Fix - adopt if a viewlet extension is disabled/removed * Avoid command palette entry (microsoft#49340) * [handlebars] code-folding algorithm is less useful than Indentation-based one. Fixes microsoft#48457 * use upper lang id * Fixes microsoft#49378 * microsoft#49145 Store placeholder states for all viewlets * Add `logicalLine` argument to `mutlicursor.insertBelow` and `mutlicursor.insertAbove` * Removed duplicate loop * eliminate code duplication; use resolveWorkspaceFolder() * microsoft#45663 Get all asset types * [css] update service * [html] update services * grid - fix compile * add User-Id to marketplace build requests * Improve rendererType description Fixes microsoft#50617 * fix microsoft#50672 * Fixes microsoft#49173 * fix microsoft#50321 * fix microsoft#50670 * Install option not needed when we have Install and Restart Fixes microsoft#50669 * Fixes microsoft#50616, Showing/hiding details in Issue Reporter resets scroll position * Fix microsoft#50642, fix microsoft#50673 * Issue reporter and process explorer windows should close when the parent window closes, fixes microsoft#50716 * Issue Reporter should clear the error state when selecting an extension, fixes microsoft#50702 * Extracting methods * Make sure we update the webview's state on setState * Avoid prompting for same file type in the same session microsoft#50537 * Use language name instead of locale in the prompt microsoft#50738 * Use correct failed error code for webview resource load error * Mark unused parameter * Restore restart * Try serializing webviews even if they have not called setState Fixes microsoft#50752 * Change parameter name to match interface name Fixes microsoft#50745 * Fix non-serializable webviews being revived if they called setState * Include recommended extensions in telemetry events to determine success * Fix microsoft#49777 - Emmet balance In after balance out should go back to initial selection and not first child (microsoft#49996) * Update Emmet - balance.ts * Cover all cases * Update prompt msg Fixes microsoft#50738 * Fix microsoft#50632 * search-rg has no icon * EH search - replace search.enableSearchProviders with a search-rg specific setting * fix microsoft#50742 * fix microsoft#50691 * part of microsoft#50760 * smoke: uncomment debug suite * smoketest: use yarn * grid - allow to close empty groups via middle click (microsoft#50733) * careful with path comparisons on windows related to microsoft#50760 * smoke: run yarn verbose * fix microsoft#50710 * Improve description (microsoft#43208) * fix microsoft#50722 * Fix microsoft#50663 * Fix microsoft#47586 * fixes microsoft#50609 * fixes microsoft#50026 * 💄 * fix microsoft#50773 * improve perf of findId and getElementById, microsoft#50575 * don't show outline when there are more then 7500 symbols, microsoft#50575 * fix typos * polish for microsoft#50667 * fix microsoft#50700 * grid keep sizing after branch node demotion fixes microsoft#50564 * grid - for now remove editorGroup.activeEmptyBackground * fix microsoft#50726 * grid: resize views when branch is demoted fixes microsoft#50675 * fix microsoft#50727 * fix microsoft#50734 * remove preview rant from search.location * splitview: dont propagate white-sapce property fixes microsoft#50720 * fix microsoft#50774 * Fixes microsoft#50296 * fix microsoft#50207 * Fixes microsoft#24670: Add API to determine if the task service supports parallel task execution. * fix microsoft#50741 * Fixes microsoft#49400: Cannot read property 'then' of undefined * Fix microsoft#50717 * Fix microsoft#48901 * polish debug.toolBarLocation fixes microsoft#50786 * Fix microsoft#50717 * missing compilation * Fix microsoft#48225 * fix microsoft#50711 * Fix errors installing extension from Welcome page (fixes microsoft#50753) * fixes microsoft#50794 * fixes microsoft#50787 * continuous build: use vsts npm feed * Fix for microsoft#50792: empty pre post scripts not rendered properly * Fix microsoft#50728 * continuous build: use vsts feed * Fix for microsoft#50792 npm exclude doesn´t work for folder names * Move previewOptions, microsoft#50788 * build: remove npm auth * better fix for microsoft#50710 * Revert "Merge pull request microsoft#49790 from usernamehw/raw_settings" This reverts commit f92a162, reversing changes made to fc710af. * Remove unused variable * Fix regression in C# TextMate grammar related to lambda parameters This tweak fixes a regression recently introduced in the C# TextMate grammar around implicitly-typed lambda parameters. * dotnet/csharp-tmLanguage#119 * dotnet/csharp-tmLanguage#120 * Fix parameter not being escaped Fixes microsoft#49057 * wip: grid.getNeighborViews * Make sure we use normalized path for compare Fixes microsoft#50760 (the path should already have been normalized at this point so I don't think there is any user impact) * Clean up importModuleSpecifier wording Fixes microsoft#50817 * Remove duplicate strings and small cleanup * Spelling fix Ouoting -> Quoting * Restore default settings editor keybinding * Dont trigger emmet for # in selectors Fixes microsoft#49269 * Hide settings editor feedback button in stable * Use better colors for markdown code blocks * Moving webview api back to proposed for more polishing microsoft#49022 * Shorten showUnused setting name Fixes microsoft#50648 * fix microsoft#50678 * Don't include imports in js/ts document symbol results Fixes microsoft#50829 * smoketest: remove verbose from yarn * smoketest: clear state from failing search tests * minor rename * Fix markdown preview not setting context properly on first creation Fixes microsoft#50558 * smoketest: update to package-lock.json fixes microsoft#50857 * smoketest: bring back search tests * microsoft#48901 Expand by default only in custom viewlets * fixes microsoft#50812 * open editors: clear focus when group without editors is active fixes microsoft#50563 * Fix MaxNumber incrementFileName bug * Fixes microsoft#48758: Do not import standalone editor modules * fixes microsoft#50864 * Use `MAX_SAFE_SMALL_INTEGER` * Fixes microsoft#50858: Task api is still marked as proposed * fixes microsoft#50737 * fix microsoft#50867 * Fix: showQuickPick keeps showing infinite progress (fixes microsoft#50863) * Clarify for translation (fixes microsoft#50634) * fixes microsoft#50870 * fix microsoft#50479 * grid - todo@grid => todo@ben * grid - adopt new getNeighborViews() method * grid - add workbench.action.closeEditorsAndGroup * open editors: close group action fixes microsoft#50625 * open editors: use actionRunner for contexts fixes microsoft#50621 * [css][html] update service * grid: getNeighborViews * grid - adopt wrapping * Some menu action clients (ActionBar) handle alternative actions on their own so the alternative actions should be ignored fixes microsoft#50581 * fillInActionBarActions and fillInContextMenuActions for clarity * Remove inconsistent use of active in terminal API Related microsoft#48434 * Try using fixAllDescription for js/ts quick fixes Fixes microsoft#42549 * Fixes microsoft#50828, code-insiders --status triggered exception in main process * Pick up ts 2.9.1 final * Fix for microsoft#50868 and microsoft#50884 * Still gray out vars even if user has disabled suggestions Fixes microsoft#50890 * grid: fix neighbor npe issue * grid: more getNeighborViews tests * grid: use boundaries for neighbor finding * grid: getNeighborViews perf * grid: add todo * 2018-05-31. Merged in translations from Transifex. * Update GDPR annotation * update message * Add specific `refactor.move` scope for js/ts move to new file action * Use localized language name when available * Add proper contribution schema for ts server pluguins microsoft#50682 * Fix extra word * Fix microsoft#50909 - add link to new settings editor from old one * Left-align settings editor preview prompt * grid - fix issues with touchbar updating * grid - use viewColumnToEditorGroup in more places * grid - close all groups should preserve first group * Reapply fix for microsoft#50790 * grid - assign some default keybindings for focus group * Fixes microsoft#50763: All running Visual Studio code instances shutdown all at once * grid - 💄 * fixes microsoft#50926 * show alternative actions when alt is pressed, not only on mouse over * open editors: click on groups should activate them * update description (for microsoft#50677) * Fix microsoft#50835 * grid - tweak some groups access order * one more time, fix microsoft#50321 * beware of keybinding command null arguments fixes microsoft#50821 * grid - prevent multiple confirmation dialogs for the same editor to show up (for microsoft#50539) * smoketest: go-to-definition is flaky fixes microsoft#50944 fixes microsoft#49107 * Fixes microsoft#50943: TSC version 2.9.x in watch mode prints different end compile message * grid - fix bad === for editors * 💄 grid, cleanup getViews() * Update distro commit and third party notices * Use localizedLanguageName instead of languageNameLocalized which doesnt exist * Remove now unneeded any * Make sure unused diags are still updated when suggestions are disabled Fixes microsoft#50890 * Fix unused var * Update version * Update issue templates, microsoft#49380 * Fix microsoft#50893 - escape regex chars when copy search string from editor * Fix microsoft#50985 - don't take editor text when toggling search details
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this issue
Nov 25, 2022
* Merge NPM Scripts: Added configuration option to change default click action microsoft#49282 * fix microsoft#50560 * Fix getmac test (microsoft#48804) * Cleaning up some typos in vscode.d.ts and vscode.proposed.d.ts (microsoft#50533) * yarn.lock changes * grid - log serialized state if restoring failed * Fixes microsoft#50382: Align .mtku with .detected-link * debug issues back to isidorn * Hide interactive playground commands from command palette (fixes microsoft#49706) * grid - drop outline as focus indication and rely on dimmed state * grid - allow to close empty group when closing all editors of a group * grid - get preferredSize from grid * Fixes microsoft#43003: Cannot specify a global problemMatcher in tasks.json * cleanup integrated terminal support for debugging * grid - action wording tweaks * microsoft#45663 Use core translations asset * grid - allow to close dirty diff editor if master is still opened in same group * Support to run npm install from a package node * grid - log previous UI state upon error * grid - stronger border top color otherwise when a tab is showing in a vertical split, the border collides with the sash border * remove todo * do not append logLevel microsoft#47774 * Implement Go To Next/Previous Breakpoint editor actions * Include enabledOnly in debug model interface * remove from schema microsoft#47774 * microsoft#45663 fix compilations * change openBreakpointSource to use IBreakpoint * return passed context if resourceOrContext is not useful * fix off by one issue * Simplify implementation * return context if it has a groupId * polish * Fixes microsoft/monaco-editor#891: Focus editor when returning from context menu * go to next / previosu breakpoint minor polish * Add Endgame for 1.24 * fix index computing for editor close case * Fix microsoft#49145 - Enable/Disable viewlets by views when context - Move viewlet enablement/disablement to views service - Fix - adopt if a viewlet extension is disabled/removed * Avoid command palette entry (microsoft#49340) * [handlebars] code-folding algorithm is less useful than Indentation-based one. Fixes microsoft#48457 * use upper lang id * Fixes microsoft#49378 * microsoft#49145 Store placeholder states for all viewlets * Add `logicalLine` argument to `mutlicursor.insertBelow` and `mutlicursor.insertAbove` * Removed duplicate loop * eliminate code duplication; use resolveWorkspaceFolder() * microsoft#45663 Get all asset types * [css] update service * [html] update services * grid - fix compile * add User-Id to marketplace build requests * Improve rendererType description Fixes microsoft#50617 * fix microsoft#50672 * Fixes microsoft#49173 * fix microsoft#50321 * fix microsoft#50670 * Install option not needed when we have Install and Restart Fixes microsoft#50669 * Fixes microsoft#50616, Showing/hiding details in Issue Reporter resets scroll position * Fix microsoft#50642, fix microsoft#50673 * Issue reporter and process explorer windows should close when the parent window closes, fixes microsoft#50716 * Issue Reporter should clear the error state when selecting an extension, fixes microsoft#50702 * Extracting methods * Make sure we update the webview's state on setState * Avoid prompting for same file type in the same session microsoft#50537 * Use language name instead of locale in the prompt microsoft#50738 * Use correct failed error code for webview resource load error * Mark unused parameter * Restore restart * Try serializing webviews even if they have not called setState Fixes microsoft#50752 * Change parameter name to match interface name Fixes microsoft#50745 * Fix non-serializable webviews being revived if they called setState * Include recommended extensions in telemetry events to determine success * Fix microsoft#49777 - Emmet balance In after balance out should go back to initial selection and not first child (microsoft#49996) * Update Emmet - balance.ts * Cover all cases * Update prompt msg Fixes microsoft#50738 * Fix microsoft#50632 * search-rg has no icon * EH search - replace search.enableSearchProviders with a search-rg specific setting * fix microsoft#50742 * fix microsoft#50691 * part of microsoft#50760 * smoke: uncomment debug suite * smoketest: use yarn * grid - allow to close empty groups via middle click (microsoft#50733) * careful with path comparisons on windows related to microsoft#50760 * smoke: run yarn verbose * fix microsoft#50710 * Improve description (microsoft#43208) * fix microsoft#50722 * Fix microsoft#50663 * Fix microsoft#47586 * fixes microsoft#50609 * fixes microsoft#50026 * 💄 * fix microsoft#50773 * improve perf of findId and getElementById, microsoft#50575 * don't show outline when there are more then 7500 symbols, microsoft#50575 * fix typos * polish for microsoft#50667 * fix microsoft#50700 * grid keep sizing after branch node demotion fixes microsoft#50564 * grid - for now remove editorGroup.activeEmptyBackground * fix microsoft#50726 * grid: resize views when branch is demoted fixes microsoft#50675 * fix microsoft#50727 * fix microsoft#50734 * remove preview rant from search.location * splitview: dont propagate white-sapce property fixes microsoft#50720 * fix microsoft#50774 * Fixes microsoft#50296 * fix microsoft#50207 * Fixes microsoft#24670: Add API to determine if the task service supports parallel task execution. * fix microsoft#50741 * Fixes microsoft#49400: Cannot read property 'then' of undefined * Fix microsoft#50717 * Fix microsoft#48901 * polish debug.toolBarLocation fixes microsoft#50786 * Fix microsoft#50717 * missing compilation * Fix microsoft#48225 * fix microsoft#50711 * Fix errors installing extension from Welcome page (fixes microsoft#50753) * fixes microsoft#50794 * fixes microsoft#50787 * continuous build: use vsts npm feed * Fix for microsoft#50792: empty pre post scripts not rendered properly * Fix microsoft#50728 * continuous build: use vsts feed * Fix for microsoft#50792 npm exclude doesn´t work for folder names * Move previewOptions, microsoft#50788 * build: remove npm auth * better fix for microsoft#50710 * Revert "Merge pull request microsoft#49790 from usernamehw/raw_settings" This reverts commit f92a162, reversing changes made to fc710af. * Remove unused variable * Fix regression in C# TextMate grammar related to lambda parameters This tweak fixes a regression recently introduced in the C# TextMate grammar around implicitly-typed lambda parameters. * dotnet/csharp-tmLanguage#119 * dotnet/csharp-tmLanguage#120 * Fix parameter not being escaped Fixes microsoft#49057 * wip: grid.getNeighborViews * Make sure we use normalized path for compare Fixes microsoft#50760 (the path should already have been normalized at this point so I don't think there is any user impact) * Clean up importModuleSpecifier wording Fixes microsoft#50817 * Remove duplicate strings and small cleanup * Spelling fix Ouoting -> Quoting * Restore default settings editor keybinding * Dont trigger emmet for # in selectors Fixes microsoft#49269 * Hide settings editor feedback button in stable * Use better colors for markdown code blocks * Moving webview api back to proposed for more polishing microsoft#49022 * Shorten showUnused setting name Fixes microsoft#50648 * fix microsoft#50678 * Don't include imports in js/ts document symbol results Fixes microsoft#50829 * smoketest: remove verbose from yarn * smoketest: clear state from failing search tests * minor rename * Fix markdown preview not setting context properly on first creation Fixes microsoft#50558 * smoketest: update to package-lock.json fixes microsoft#50857 * smoketest: bring back search tests * microsoft#48901 Expand by default only in custom viewlets * fixes microsoft#50812 * open editors: clear focus when group without editors is active fixes microsoft#50563 * Fix MaxNumber incrementFileName bug * Fixes microsoft#48758: Do not import standalone editor modules * fixes microsoft#50864 * Use `MAX_SAFE_SMALL_INTEGER` * Fixes microsoft#50858: Task api is still marked as proposed * fixes microsoft#50737 * fix microsoft#50867 * Fix: showQuickPick keeps showing infinite progress (fixes microsoft#50863) * Clarify for translation (fixes microsoft#50634) * fixes microsoft#50870 * fix microsoft#50479 * grid - todo@grid => todo@ben * grid - adopt new getNeighborViews() method * grid - add workbench.action.closeEditorsAndGroup * open editors: close group action fixes microsoft#50625 * open editors: use actionRunner for contexts fixes microsoft#50621 * [css][html] update service * grid: getNeighborViews * grid - adopt wrapping * Some menu action clients (ActionBar) handle alternative actions on their own so the alternative actions should be ignored fixes microsoft#50581 * fillInActionBarActions and fillInContextMenuActions for clarity * Remove inconsistent use of active in terminal API Related microsoft#48434 * Try using fixAllDescription for js/ts quick fixes Fixes microsoft#42549 * Fixes microsoft#50828, code-insiders --status triggered exception in main process * Pick up ts 2.9.1 final * Fix for microsoft#50868 and microsoft#50884 * Still gray out vars even if user has disabled suggestions Fixes microsoft#50890 * grid: fix neighbor npe issue * grid: more getNeighborViews tests * grid: use boundaries for neighbor finding * grid: getNeighborViews perf * grid: add todo * 2018-05-31. Merged in translations from Transifex. * Update GDPR annotation * update message * Add specific `refactor.move` scope for js/ts move to new file action * Use localized language name when available * Add proper contribution schema for ts server pluguins microsoft#50682 * Fix extra word * Fix microsoft#50909 - add link to new settings editor from old one * Left-align settings editor preview prompt * grid - fix issues with touchbar updating * grid - use viewColumnToEditorGroup in more places * grid - close all groups should preserve first group * Reapply fix for microsoft#50790 * grid - assign some default keybindings for focus group * Fixes microsoft#50763: All running Visual Studio code instances shutdown all at once * grid - 💄 * fixes microsoft#50926 * show alternative actions when alt is pressed, not only on mouse over * open editors: click on groups should activate them * update description (for microsoft#50677) * Fix microsoft#50835 * grid - tweak some groups access order * one more time, fix microsoft#50321 * beware of keybinding command null arguments fixes microsoft#50821 * grid - prevent multiple confirmation dialogs for the same editor to show up (for microsoft#50539) * smoketest: go-to-definition is flaky fixes microsoft#50944 fixes microsoft#49107 * Fixes microsoft#50943: TSC version 2.9.x in watch mode prints different end compile message * grid - fix bad === for editors * 💄 grid, cleanup getViews() * Update distro commit and third party notices * Use localizedLanguageName instead of languageNameLocalized which doesnt exist * Remove now unneeded any * Make sure unused diags are still updated when suggestions are disabled Fixes microsoft#50890 * Fix unused var * Update version * Update issue templates, microsoft#49380 * Fix microsoft#50893 - escape regex chars when copy search string from editor * Fix microsoft#50985 - don't take editor text when toggling search details
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this issue
Nov 25, 2022
* Merge NPM Scripts: Added configuration option to change default click action microsoft#49282 * fix microsoft#50560 * Fix getmac test (microsoft#48804) * Cleaning up some typos in vscode.d.ts and vscode.proposed.d.ts (microsoft#50533) * yarn.lock changes * grid - log serialized state if restoring failed * Fixes microsoft#50382: Align .mtku with .detected-link * debug issues back to isidorn * Hide interactive playground commands from command palette (fixes microsoft#49706) * grid - drop outline as focus indication and rely on dimmed state * grid - allow to close empty group when closing all editors of a group * grid - get preferredSize from grid * Fixes microsoft#43003: Cannot specify a global problemMatcher in tasks.json * cleanup integrated terminal support for debugging * grid - action wording tweaks * microsoft#45663 Use core translations asset * grid - allow to close dirty diff editor if master is still opened in same group * Support to run npm install from a package node * grid - log previous UI state upon error * grid - stronger border top color otherwise when a tab is showing in a vertical split, the border collides with the sash border * remove todo * do not append logLevel microsoft#47774 * Implement Go To Next/Previous Breakpoint editor actions * Include enabledOnly in debug model interface * remove from schema microsoft#47774 * microsoft#45663 fix compilations * change openBreakpointSource to use IBreakpoint * return passed context if resourceOrContext is not useful * fix off by one issue * Simplify implementation * return context if it has a groupId * polish * Fixes microsoft/monaco-editor#891: Focus editor when returning from context menu * go to next / previosu breakpoint minor polish * Add Endgame for 1.24 * fix index computing for editor close case * Fix microsoft#49145 - Enable/Disable viewlets by views when context - Move viewlet enablement/disablement to views service - Fix - adopt if a viewlet extension is disabled/removed * Avoid command palette entry (microsoft#49340) * [handlebars] code-folding algorithm is less useful than Indentation-based one. Fixes microsoft#48457 * use upper lang id * Fixes microsoft#49378 * microsoft#49145 Store placeholder states for all viewlets * Add `logicalLine` argument to `mutlicursor.insertBelow` and `mutlicursor.insertAbove` * Removed duplicate loop * eliminate code duplication; use resolveWorkspaceFolder() * microsoft#45663 Get all asset types * [css] update service * [html] update services * grid - fix compile * add User-Id to marketplace build requests * Improve rendererType description Fixes microsoft#50617 * fix microsoft#50672 * Fixes microsoft#49173 * fix microsoft#50321 * fix microsoft#50670 * Install option not needed when we have Install and Restart Fixes microsoft#50669 * Fixes microsoft#50616, Showing/hiding details in Issue Reporter resets scroll position * Fix microsoft#50642, fix microsoft#50673 * Issue reporter and process explorer windows should close when the parent window closes, fixes microsoft#50716 * Issue Reporter should clear the error state when selecting an extension, fixes microsoft#50702 * Extracting methods * Make sure we update the webview's state on setState * Avoid prompting for same file type in the same session microsoft#50537 * Use language name instead of locale in the prompt microsoft#50738 * Use correct failed error code for webview resource load error * Mark unused parameter * Restore restart * Try serializing webviews even if they have not called setState Fixes microsoft#50752 * Change parameter name to match interface name Fixes microsoft#50745 * Fix non-serializable webviews being revived if they called setState * Include recommended extensions in telemetry events to determine success * Fix microsoft#49777 - Emmet balance In after balance out should go back to initial selection and not first child (microsoft#49996) * Update Emmet - balance.ts * Cover all cases * Update prompt msg Fixes microsoft#50738 * Fix microsoft#50632 * search-rg has no icon * EH search - replace search.enableSearchProviders with a search-rg specific setting * fix microsoft#50742 * fix microsoft#50691 * part of microsoft#50760 * smoke: uncomment debug suite * smoketest: use yarn * grid - allow to close empty groups via middle click (microsoft#50733) * careful with path comparisons on windows related to microsoft#50760 * smoke: run yarn verbose * fix microsoft#50710 * Improve description (microsoft#43208) * fix microsoft#50722 * Fix microsoft#50663 * Fix microsoft#47586 * fixes microsoft#50609 * fixes microsoft#50026 * 💄 * fix microsoft#50773 * improve perf of findId and getElementById, microsoft#50575 * don't show outline when there are more then 7500 symbols, microsoft#50575 * fix typos * polish for microsoft#50667 * fix microsoft#50700 * grid keep sizing after branch node demotion fixes microsoft#50564 * grid - for now remove editorGroup.activeEmptyBackground * fix microsoft#50726 * grid: resize views when branch is demoted fixes microsoft#50675 * fix microsoft#50727 * fix microsoft#50734 * remove preview rant from search.location * splitview: dont propagate white-sapce property fixes microsoft#50720 * fix microsoft#50774 * Fixes microsoft#50296 * fix microsoft#50207 * Fixes microsoft#24670: Add API to determine if the task service supports parallel task execution. * fix microsoft#50741 * Fixes microsoft#49400: Cannot read property 'then' of undefined * Fix microsoft#50717 * Fix microsoft#48901 * polish debug.toolBarLocation fixes microsoft#50786 * Fix microsoft#50717 * missing compilation * Fix microsoft#48225 * fix microsoft#50711 * Fix errors installing extension from Welcome page (fixes microsoft#50753) * fixes microsoft#50794 * fixes microsoft#50787 * continuous build: use vsts npm feed * Fix for microsoft#50792: empty pre post scripts not rendered properly * Fix microsoft#50728 * continuous build: use vsts feed * Fix for microsoft#50792 npm exclude doesn´t work for folder names * Move previewOptions, microsoft#50788 * build: remove npm auth * better fix for microsoft#50710 * Revert "Merge pull request microsoft#49790 from usernamehw/raw_settings" This reverts commit f92a162, reversing changes made to fc710af. * Remove unused variable * Fix regression in C# TextMate grammar related to lambda parameters This tweak fixes a regression recently introduced in the C# TextMate grammar around implicitly-typed lambda parameters. * dotnet/csharp-tmLanguage#119 * dotnet/csharp-tmLanguage#120 * Fix parameter not being escaped Fixes microsoft#49057 * wip: grid.getNeighborViews * Make sure we use normalized path for compare Fixes microsoft#50760 (the path should already have been normalized at this point so I don't think there is any user impact) * Clean up importModuleSpecifier wording Fixes microsoft#50817 * Remove duplicate strings and small cleanup * Spelling fix Ouoting -> Quoting * Restore default settings editor keybinding * Dont trigger emmet for # in selectors Fixes microsoft#49269 * Hide settings editor feedback button in stable * Use better colors for markdown code blocks * Moving webview api back to proposed for more polishing microsoft#49022 * Shorten showUnused setting name Fixes microsoft#50648 * fix microsoft#50678 * Don't include imports in js/ts document symbol results Fixes microsoft#50829 * smoketest: remove verbose from yarn * smoketest: clear state from failing search tests * minor rename * Fix markdown preview not setting context properly on first creation Fixes microsoft#50558 * smoketest: update to package-lock.json fixes microsoft#50857 * smoketest: bring back search tests * microsoft#48901 Expand by default only in custom viewlets * fixes microsoft#50812 * open editors: clear focus when group without editors is active fixes microsoft#50563 * Fix MaxNumber incrementFileName bug * Fixes microsoft#48758: Do not import standalone editor modules * fixes microsoft#50864 * Use `MAX_SAFE_SMALL_INTEGER` * Fixes microsoft#50858: Task api is still marked as proposed * fixes microsoft#50737 * fix microsoft#50867 * Fix: showQuickPick keeps showing infinite progress (fixes microsoft#50863) * Clarify for translation (fixes microsoft#50634) * fixes microsoft#50870 * fix microsoft#50479 * grid - todo@grid => todo@ben * grid - adopt new getNeighborViews() method * grid - add workbench.action.closeEditorsAndGroup * open editors: close group action fixes microsoft#50625 * open editors: use actionRunner for contexts fixes microsoft#50621 * [css][html] update service * grid: getNeighborViews * grid - adopt wrapping * Some menu action clients (ActionBar) handle alternative actions on their own so the alternative actions should be ignored fixes microsoft#50581 * fillInActionBarActions and fillInContextMenuActions for clarity * Remove inconsistent use of active in terminal API Related microsoft#48434 * Try using fixAllDescription for js/ts quick fixes Fixes microsoft#42549 * Fixes microsoft#50828, code-insiders --status triggered exception in main process * Pick up ts 2.9.1 final * Fix for microsoft#50868 and microsoft#50884 * Still gray out vars even if user has disabled suggestions Fixes microsoft#50890 * grid: fix neighbor npe issue * grid: more getNeighborViews tests * grid: use boundaries for neighbor finding * grid: getNeighborViews perf * grid: add todo * 2018-05-31. Merged in translations from Transifex. * Update GDPR annotation * update message * Add specific `refactor.move` scope for js/ts move to new file action * Use localized language name when available * Add proper contribution schema for ts server pluguins microsoft#50682 * Fix extra word * Fix microsoft#50909 - add link to new settings editor from old one * Left-align settings editor preview prompt * grid - fix issues with touchbar updating * grid - use viewColumnToEditorGroup in more places * grid - close all groups should preserve first group * Reapply fix for microsoft#50790 * grid - assign some default keybindings for focus group * Fixes microsoft#50763: All running Visual Studio code instances shutdown all at once * grid - 💄 * fixes microsoft#50926 * show alternative actions when alt is pressed, not only on mouse over * open editors: click on groups should activate them * update description (for microsoft#50677) * Fix microsoft#50835 * grid - tweak some groups access order * one more time, fix microsoft#50321 * beware of keybinding command null arguments fixes microsoft#50821 * grid - prevent multiple confirmation dialogs for the same editor to show up (for microsoft#50539) * smoketest: go-to-definition is flaky fixes microsoft#50944 fixes microsoft#49107 * Fixes microsoft#50943: TSC version 2.9.x in watch mode prints different end compile message * grid - fix bad === for editors * 💄 grid, cleanup getViews() * Update distro commit and third party notices * Use localizedLanguageName instead of languageNameLocalized which doesnt exist * Remove now unneeded any * Make sure unused diags are still updated when suggestions are disabled Fixes microsoft#50890 * Fix unused var * Update version * Update issue templates, microsoft#49380 * Fix microsoft#50893 - escape regex chars when copy search string from editor * Fix microsoft#50985 - don't take editor text when toggling search details
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With
"noUnusedLocals": true:With it set to
false:From #50487 I got the impression that when it's set to false (or not set at all), greying out should still happen.
Repro:
yo codefor a TS projectThe text was updated successfully, but these errors were encountered: