Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative version number field to manifest to make correlation with entries in Add/Remove programs more reliable #980

Closed
chausner opened this issue May 21, 2021 · 6 comments · Fixed by #2213
Assignees
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@chausner
Copy link
Contributor

Description of the new feature/enhancement

As reported here, the winget upgrade command may incorrectly detect updates to be available even when the latest version is installed in case the version number in Add/Remove programs does not match the package version in the manifest.

One solution to this problem could be the addition of an additional version field to the manifest where the version number is specified in the format that is expected in Add/Remove programs. When present, the winget upgrade routine would use this version number instead of the package version to determine if an update is available or not.

This suggestion is closely related to microsoft/winget-pkgs#13620.

@denelon
Copy link
Contributor

denelon commented May 21, 2021

@chausner we have another issue in the client I think this is a duplicate of #976.

Edit: I didn't read fully.

@denelon
Copy link
Contributor

denelon commented May 21, 2021

I moved this to be a feature in the client.

@denelon denelon transferred this issue from microsoft/winget-pkgs May 21, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label May 21, 2021
@denelon denelon added Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client. and removed Needs-Triage Issue need to be triaged labels May 21, 2021
@denelon
Copy link
Contributor

denelon commented Dec 1, 2021

This is part of the work we're doing with the new schema. We have added a section for data specifically matching what is reported via Apps & Features.

@denelon
Copy link
Contributor

denelon commented Feb 18, 2022

@denelon
Copy link
Contributor

denelon commented May 3, 2022

We're going to use this Issue to represent the work to start looking at the version in the AppsAndFeatures section of the manifest (if it is populated) rather than the PackageVersion for version comparison.

PackageVersion:         # Used for version comparison if no DisplayVersion key is present
- AppsAndFeatures
    DisplayVersion:     # Used for version comparison if the key is present

@denelon
Copy link
Contributor

denelon commented May 5, 2022

When we have an installed package and the manifest in the repository uses the AppsAndFeatures version we need a rational way to display the "somewhat unknown" "displayVersion" to the user.

The example below is contrived, but is intended to illustrate the syntax we're considering using.

We're thinking of using "> " for the winget list scenario where the user has a newer version installed.

Name           Id                   Version   Available Source
------------------------------------------------------------
Git            Git.Git              > 2.36.0            winget
GitHub Desktop GitHub.GitHubDesktop 2.9.15    3.0.0     winget

We're thinking of using "< " for the winget upgrade scenario where the users has an older version installed, but it doesn't match an existing manifest.

Name           Id                   Version   Available Source
------------------------------------------------------------
Git            Git.Git              < 2.36.0  2.36.0    winget
GitHub Desktop GitHub.GitHubDesktop 2.9.15    3.0.0     winget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
3 participants