Update #2
Merged
Update #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… going to match the enum name - now that we camelCase variable names this cuts down on the amount of enum escaping we have.
Resolving an issue with serializing classes that contain required properties. When the only constructor has defaulted parameters, no parameterless constructor is generated but JSON.Net attempts to call the missing constructor on deserialization (because of DataContract). See: https://manski.net/2014/10/net-serializers-comparison-chart/ The fix here is to create a protected constructor, annotate it with JsonConstructorAttribute to inform JSON.Net it is the constructor to use during serialization, then provide settings that explicitly allow JSON.Net to access non-public constructors during serialiazation.
In Angular.js, values are injected into service in one of two ways: 1) Inline (by name). 2) By a static injector variable. The TypeScript generator uses the 2nd method. This method requires you to explicitly enumerate all the values you would like to have injected. If you fail to inject a value the Angular DI system will simply pass you `undefined`. The constructor is expecting 3 values to be passed (the final being basePath) but the injector static only defines 2 values. This results in basePath always being undefined no matter what you define it to be. This change updates the injector variable to handle that properly.
In Angular if a value is not defined for injection it is passed as
undefined. That means that most of the time `if (value) {` is a
reasonable test. Unfortunately since `""` (empty string) is also falsey
by nature, an empty string will not trigger the if properly.
Instead you should check `if (value !== undefined) {`.
…equest method for easier override to modify request.
…odegen into jaz-ah-swift/podupdate Conflicts: samples/client/petstore/swift/SwaggerClientTests/Pods/Pods.xcodeproj/project.pbxproj
[Javascript][Clojure] Fix mediaType
add gradle wrapper mustache for android api client;
Add Ruby enum support
…ould_generate_correct_output Feature/typescript angular2 should generate correct output
show security defs
[C#] fix csharp constructor for model with read-only 1st property
[Swift] Add sample/tests for Swift client without PromiseKit
initalise=> initialize
Mispelling in Objective-C initialization
codition => condition
Misspellings
Mispelling in Objective-C initialization template
[PHP] add enum test in PHP API client
typescript-angular2 query string fix
…er-codegen into zhenjun115-java_api_client
mikolajpe
pushed a commit
that referenced
this pull request
Oct 5, 2016
* Initial erlang generation * Recfactor erlang codegen to make a minimal working example * ft/erlang_codegen Separate handlers by resourse, add minor codegen fixes and refactoring * Test commit * ft/erlang_codegen Modify reouting generation * ft/erlang_codegen Remove parsed request concept. Add minor refactoring and bugfixes * ft/erlang_codegen Use swagger spec from an internal directory instead of a provided path * ft/erlang_codegen Add basic response validation * ft/erlang_codegen Moved all the req validators to a separate file for test needs * ft/erlang_codegen Add basic param validation * Add refactoring: OperationIDs are atoms now Fix schema validation Add todo list * CAPI-23 Add auth context to request handling (#2) * CAPI-23 Fix routing to support different paths in one handler. Add auth context to request handling. Add an opportunity to pass custom middlewares to the server * CAPI-31 Add enum validation and some minor fixes (#4) * CAPI-31 Fix turbo fuck up with additional params (#5) * Capi 23/fix/basic logging (swagger-api#6) * CAPI-23 Add understandable messages in case of bad requests. Add specs to shut up dialyzer and add some minor code refactoring * CAPI-23 Fix missed bracket in auth module (swagger-api#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.