Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in Report Overview #3707

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Fixes in Report Overview #3707

merged 8 commits into from
Oct 28, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Oct 21, 2024 •
edited
Loading

Changes

This PR makes the following changes to the Report Overview:

  • Fix the breadcrumbs
  • Change the page description text on the Scheduled Reports page
  • Change the page description text on the Reports History page
  • If scheduled_reports_table or reports_history_table is empty, show an empty state text (instead of an empty table)
  • Remove the "Subreport Name" column in the Scheduled Reports table

Demo

afbeelding
afbeelding
afbeelding

QA notes

  • Go to the Report page.
  • Check the two tabs "History" and "Scheduled". Check the intro text and the empty state text.
  • Create a report without schedule and a scheduled report
  • Check the two tabs again. The table should be visible (no empty state text) and counter should work

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen self-assigned this Oct 21, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner October 21, 2024 12:16
@noamblitz
Copy link
Contributor

noamblitz commented Oct 24, 2024 •
edited
Loading

QA checklist for PR's

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

  • Message shown correctly when no reports available.
  • Messages disappear when reports available.

What doesn't work:

image

Styling incorrect

Bug or feature?:

  • bullet point + screenshot (if useful) if it is unclear whether something is a bug or an intended feature.

@madelondohmen
Copy link
Contributor Author

What doesn't work:

image

Styling incorrect

@noamblitz Weird, this is what I see:
afbeelding

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@noamblitz
Copy link
Contributor

Its only when there are no reports.

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good. The styling bug is either resolved, or a specific bug to the environment from @noamblitz.

What doesn't work:

n/a

Bug or feature?:

Found #3734 but unrelated to this PR.

@underdarknl underdarknl merged commit 2442f45 into main Oct 28, 2024
20 of 22 checks passed
@underdarknl underdarknl deleted the fix/report-overview branch October 28, 2024 08:45
jpbruinsslot added a commit that referenced this pull request Nov 6, 2024
@jpbruinsslot
Merge branch 'main' into chore/mula/extra-models
8720c95 
* main:
  Fix reports with organization tags (#3790)
  Update README.rst - Fix guidelines URLs (#3789)
  Exclude Report from ooi list (#3768)
  Update `croniter` (#3767)
  Fixes for dropdowns (#3732)
  Fix scheduled Aggregate Report naming (#3748)
  Make systemctl call for kat-rocky-worker conditional (#3782)
  Fix vulnerability chapters in Aggregate table of content (#3780)
  Fix auth token middleware with wrong format header (#3755)
  Add rocky REST API for report recipes (#3746)
  Add exception handling to the rest api (#3708)
  Refactor Multi Report to comply to the new report flow (#3705)
  Fix report names for scheduled reports (#3726)
  Fix Multi Report recursion error (#3714)
  Bump waitress from 3.0.0 to 3.0.1 in /octopoes (#3760)
  Docs/add muted findings (#3699)
  Edit report recipe (#3690)
  Add start date to report schedule (#3701)
  Add REST API to list report and download pdf report (#3689)
  Fixes in Report Overview (#3707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppvg ppvg ppvg left review comments

@ammar92 ammar92 ammar92 approved these changes

@underdarknl underdarknl underdarknl approved these changes

Assignees

@madelondohmen madelondohmen

Labels
frontend
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@madelondohmen @noamblitz @stephanie0x00 @ppvg @underdarknl @ammar92