Fix reports with orginization tags #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ammar92
approved these changes
Nov 4, 2024
underdarknl
reviewed
Nov 4, 2024
| @@ -90,7 +90,7 @@ def save_report_data( | |||
| report_id=uuid4(), | |||
| organization_code=organization.code, | |||
| organization_name=organization.name, | |||
| organization_tags=list(organization.tags.all()), | |||
| organization_tags=[tag.name for tag in organization.tags.all()], | |||
There was a problem hiding this comment.
A helper function on the organization object that returns just the names would be useful, seeing that we already use this same loop in 4 places, and this will probably grow.
Checklist for QA:
What works:When generating the report no error message is thrown. What doesn't work:n/a Bug or feature?:Identified bug: #3794 but it appears to be on main. |
|
Weird, this bug should then also exist in main I'm afraid. |
underdarknl
approved these changes
Nov 4, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Nov 6, 2024
* main: Fix reports with organization tags (#3790) Update README.rst - Fix guidelines URLs (#3789) Exclude Report from ooi list (#3768) Update `croniter` (#3767) Fixes for dropdowns (#3732) Fix scheduled Aggregate Report naming (#3748) Make systemctl call for kat-rocky-worker conditional (#3782) Fix vulnerability chapters in Aggregate table of content (#3780) Fix auth token middleware with wrong format header (#3755) Add rocky REST API for report recipes (#3746) Add exception handling to the rest api (#3708) Refactor Multi Report to comply to the new report flow (#3705) Fix report names for scheduled reports (#3726) Fix Multi Report recursion error (#3714) Bump waitress from 3.0.0 to 3.0.1 in /octopoes (#3760) Docs/add muted findings (#3699) Edit report recipe (#3690) Add start date to report schedule (#3701) Add REST API to list report and download pdf report (#3689) Fixes in Report Overview (#3707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3750
Issue link
Closes #3750
QA notes
Follow steps in #3750, see that it has been solved.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.