Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Report from ooi list #3768

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Oct 30, 2024

Changes

  • Exclude Reports OOI from OOI list
  • Remove Report from filter (filter by ooi type)

Issue link

Closes ...

Demo

You cannot filter by Report ooi type anymore, it is not listed for filters:
image

Even though you filter it from the URL:
image

QA notes

Go to ooi list and see that you cannot see "Report" ooi type in the filter and also Report OOIs are not listed.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner October 30, 2024 11:24
@originalsouth originalsouth added the rocky Issues related to Rocky label Oct 30, 2024
@underdarknl
Copy link
Contributor

This should do what we expect. However, the reason why we have two locations that we need to set this list is because it shouldn't be part of the views. it should be part of the OOI models somewhere, Ideally based on the OOIType or attributes themselves instead of hard coded lists everywhere.

Copy link

sonarqubecloud bot commented Nov 1, 2024

@underdarknl underdarknl merged commit c0c525e into main Nov 1, 2024
22 checks passed
@underdarknl underdarknl deleted the fix/remove-reports-oois-from-ooi-list branch November 1, 2024 10:50
jpbruinsslot added a commit that referenced this pull request Nov 6, 2024
* main:
  Fix reports with organization tags (#3790)
  Update README.rst - Fix guidelines URLs (#3789)
  Exclude Report from ooi list (#3768)
  Update `croniter` (#3767)
  Fixes for dropdowns (#3732)
  Fix scheduled Aggregate Report naming (#3748)
  Make systemctl call for kat-rocky-worker conditional (#3782)
  Fix vulnerability chapters in Aggregate table of content (#3780)
  Fix auth token middleware with wrong format header (#3755)
  Add rocky REST API for report recipes (#3746)
  Add exception handling to the rest api (#3708)
  Refactor Multi Report to comply to the new report flow (#3705)
  Fix report names for scheduled reports (#3726)
  Fix Multi Report recursion error (#3714)
  Bump waitress from 3.0.0 to 3.0.1 in /octopoes (#3760)
  Docs/add muted findings (#3699)
  Edit report recipe (#3690)
  Add start date to report schedule (#3701)
  Add REST API to list report and download pdf report (#3689)
  Fixes in Report Overview (#3707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rocky Issues related to Rocky
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants