Rename Authenticator.server_{cert,key}_fingerprint #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
could you rebase on top of main and add a changes entry? thanks a lot |
|
since this will be part of a major release, there's no needfor deprecation, we can just add a changes entry and drop the old names |
reynir
force-pushed
the
authenticator-fingerprint
branch
from
1f481ae
to
51b4edf
Compare
By dropping the server_ prefix. The functions do not check that the certificate have extended key usage of server auth and could just as well be used to authenticate clients (although the server case is more likely).
reynir
force-pushed
the
authenticator-fingerprint
branch
from
51b4edf
to
9f6408a
Compare
hannesm
reviewed
Jul 20, 2024
|
thanks |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jul 22, 2024
What's Changed - Fix mixup of subject and hash in error message by @reynir in mirleft/ocaml-x509#165 - Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167 - Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164 - Add Certificate.fold_decode_pem_multiple by @art-w in mirleft/ocaml-x509#169 New Contributors - @art-w made their first contribution in mirleft/ocaml-x509#169
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
What's Changed - Fix mixup of subject and hash in error message by @reynir in mirleft/ocaml-x509#165 - Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167 - Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164 - Add Certificate.fold_decode_pem_multiple by @art-w in mirleft/ocaml-x509#169 New Contributors - @art-w made their first contribution in mirleft/ocaml-x509#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By dropping the server_ prefix. The functions do not check that the certificate have extended key usage of server auth and could just as well be used to authenticate clients (although the server case is more likely). The old names are kept as aliases and a deprecation attribute is added.
This may result in some churn, but judging from sherlocode it doesn't look too bad.