Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixup of subject and hash in error message #165

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Feb 22, 2024

hash algorithm /CN=snakeoil is not allowed, but SHA224 is signed using it is a funny but confusing error message :D

@hannesm hannesm merged commit f3cdac6 into mirleft:main Feb 23, 2024
1 check passed
@hannesm
Copy link
Member

hannesm commented Feb 23, 2024

thanks :)

@reynir reynir deleted the format-typo branch February 23, 2024 12:16
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jul 22, 2024
What's Changed

- Fix mixup of subject and hash in error message by @reynir in
  mirleft/ocaml-x509#165
- Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167
- Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164
- Add Certificate.fold_decode_pem_multiple by @art-w in
  mirleft/ocaml-x509#169

New Contributors

- @art-w made their first contribution in mirleft/ocaml-x509#169
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
What's Changed

- Fix mixup of subject and hash in error message by @reynir in
  mirleft/ocaml-x509#165
- Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167
- Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164
- Add Certificate.fold_decode_pem_multiple by @art-w in
  mirleft/ocaml-x509#169

New Contributors

- @art-w made their first contribution in mirleft/ocaml-x509#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants