Add Certificate.fold_decode_pem_multiple #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Jul 18, 2024
hannesm
reviewed
Jul 18, 2024
art-w
force-pushed
the
decode_pem_errors
branch
2 times, most recently
from
7582e26
to
875d338
Compare
|
thanks |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jul 22, 2024
What's Changed - Fix mixup of subject and hash in error message by @reynir in mirleft/ocaml-x509#165 - Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167 - Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164 - Add Certificate.fold_decode_pem_multiple by @art-w in mirleft/ocaml-x509#169 New Contributors - @art-w made their first contribution in mirleft/ocaml-x509#169
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
What's Changed - Fix mixup of subject and hash in error message by @reynir in mirleft/ocaml-x509#165 - Use string instead of cstruct by @dinosaure in mirleft/ocaml-x509#167 - Rename Authenticator.server_{cert,key}_fingerprint by @reynir in mirleft/ocaml-x509#164 - Add Certificate.fold_decode_pem_multiple by @art-w in mirleft/ocaml-x509#169 New Contributors - @art-w made their first contribution in mirleft/ocaml-x509#169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following mirage/ca-certs#30, @hannesm suggested that the handling of certificate parse errors from
pemwould be better handled in X509 than inca-certs, as the parsing logic there is less complete than in X509, with no support for\r\nfor example, but there's a need to ignore parse errors which wasn't possible before with x509 api alone.