Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop-rspec to version 2.14.2 #23

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 31, 2022

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.13.2 → 2.14.2) · Repo · Changelog

Release Notes

2.14.2

  • Fix an incorrect autocorrect for FactoryBot/ConsistentParenthesesStyle with omit_parentheses option when method name and first argument are not on same line. (@ydah)
  • Fix autocorrection loop in RSpec/ExampleWording for insufficient example wording. (@pirj)
  • Fix RSpec/SortMetadata not to reorder arguments of include_/it_behaves_like. (@pirj)
  • Fix a false positive for RSpec/NoExpectationExample when allowed pattern methods with arguments. (@ydah)
  • Change RSpec/FilePath so that it only checks suffix when path is under spec/routing or type is defined as routing. (@r7kamura)

2.14.1

  • Fix an error for RSpec/Rails/InferredSpecType with redundant type before other Hash metadata. (@ydah)

2.14.0

  • Add require_implicit style to RSpec/ImplicitSubject. (@r7kamura)
  • Fix a false positive for RSpec/Capybara/SpecificMatcher when have_css("a") without attribute. (@ydah)
  • Update RSpec/ExampleWording cop to raise error for insufficient descriptions. (@akrox58)
  • Add new RSpec/Capybara/NegationMatcher cop. (@ydah)
  • Add AllowedPatterns configuration option to RSpec/NoExpectationExample. (@ydah)
  • Improve RSpec/NoExpectationExample cop to ignore examples skipped or pending via metadata. (@pirj)
  • Add RSpec/FactoryBot/ConsistentParenthesesStyle cop. (@Liberatys)
  • Add RSpec/Rails/InferredSpecType cop. (@r7kamura)
  • Add new RSpec/Capybara/SpecificActions cop. (@ydah)
  • Update config/default.yml removing deprecated option to make the config correctable by users. (@ignaciovillaverde)
  • Do not attempt to auto-correct example groups with include_examples in RSpec/LetBeforeExamples. (@pirj)
  • Add new RSpec/SortMetadata cop. (@leoarnold)
  • Add support for subject! method to RSpec/SubjectDeclaration. (@ydah)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 61 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Oct 31, 2022
@mkon mkon merged commit dc49bd2 into main Oct 31, 2022
@mkon mkon deleted the depfu/update/rubocop-rspec-2.14.2 branch October 31, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant