Add raw stc #12001
Add raw stc #12001
Conversation
BabaSanfour
requested review from
larsoner,
drammock and
agramfort
as code owners
for more information, see https://pre-commit.ci
|
Not sure if the 3.10 pip are failing from my part ? |
|
CI failure does not seem related to this PR. I think it makes sense to add this functionality, although I was a bit confused by the term "raw" timecourses. I've changed the wording in the Could we add a unit test for the new functionality? |
|
@wmvanvliet the change should be fine ; The CI failure is fixed - somehow. For the unit test I will add it later today. I found this comment "# XXX we don't check pca_flip, probably should someday...". |
|
If you could yes thank you :) |
|
Not sure the errors are related to my pull request; they in viz and transform tests which I didn't touch |
for more information, see https://pre-commit.ci
|
CI failures seem related: |
|
Yes my bad, |
There was a problem hiding this comment.
I changed "raw" to be None instead, after discussion with @larsoner, and then modified the logic accordingly. We agreed that None better reflected the user request, i.e., "no aggregation strategy across vertices".
marking for merge when CIs are green again, thanks @BabaSanfour!
|
I agree it better reflects the logic of mne. Thanks for your work! Glad to contribute. |
* upstream/main: (37 commits) Use constrained layout in matplotlib visualization (mne-tools#12050) Add raw stc (mne-tools#12001) [MRG] update codeowners (mne-tools#12089) DOC: Morlet wavelet length in tfr_morlet (mne-tools#12073) BUG: Fix bug with mne browser backend (mne-tools#12078) Cache avatars (mne-tools#12077) BUG: Fix bug with ch_name resolution (mne-tools#12086) add unicode roundtrip for FIF (mne-tools#12080) add Ivan to names.inc (mne-tools#12081) MAINT: Work around PySide 6.5.3 event loop error (mne-tools#12076) mne-tools#11608, buggfix and docstring update (mne-tools#12066) MAINT: Fix broken examples (mne-tools#12074) Add UI Event linking to DraggableColorbar (mne-tools#12057) handle lazy loading through .pyi type stubs (mne-tools#12072) BUG: Fix bug with sensor_colors (mne-tools#12068) clean up some deprecations (mne-tools#12067) Allow not dropping bads when creating or plotting Spectrum objs (mne-tools#12006) Collapsible html repr for raw/info (mne-tools#12064) BUG: Fix bug with pickling MNEBadsList (mne-tools#12063) add details for Denis (mne-tools#12065) ...
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Marijn van Vliet <w.m.vanvliet@gmail.com> Co-authored-by: Daniel McCloy <dan@mccloy.info>
Add functionality to extract raw time course of a brain region
In this commit, I have extended the script to include functionality that allows users to directly access the raw time courses of a specific brain region through its label without any transformation. This enhancement enables more flexible and detailed analysis of source data.