Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unicode roundtrip for FIF #12080

Merged
merged 3 commits into from
Oct 6, 2023
Merged

add unicode roundtrip for FIF #12080

merged 3 commits into from
Oct 6, 2023

Conversation

drammock
Copy link
Member

@drammock drammock commented Oct 5, 2023

closes #11684

larsoner
larsoner approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@larsoner larsoner enabled auto-merge (squash) October 5, 2023 20:34
agramfort
agramfort approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @drammock !

@larsoner larsoner merged commit 23fa43c into mne-tools:main Oct 6, 2023
26 of 28 checks passed
@drammock drammock deleted the unicode branch October 6, 2023 10:25
@hoechenberger
Copy link
Member

@drammock super nice, thank you

larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 10, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into kernel
f952d58 
* upstream/main: (37 commits)
  Use constrained layout in matplotlib visualization (mne-tools#12050)
  Add raw stc (mne-tools#12001)
  [MRG] update codeowners (mne-tools#12089)
  DOC: Morlet wavelet length in tfr_morlet (mne-tools#12073)
  BUG: Fix bug with mne browser backend (mne-tools#12078)
  Cache avatars (mne-tools#12077)
  BUG: Fix bug with ch_name resolution (mne-tools#12086)
  add unicode roundtrip for FIF (mne-tools#12080)
  add Ivan to names.inc (mne-tools#12081)
  MAINT: Work around PySide 6.5.3 event loop error (mne-tools#12076)
  mne-tools#11608, buggfix and docstring update (mne-tools#12066)
  MAINT: Fix broken examples (mne-tools#12074)
  Add UI Event linking to DraggableColorbar (mne-tools#12057)
  handle lazy loading through .pyi type stubs (mne-tools#12072)
  BUG: Fix bug with sensor_colors (mne-tools#12068)
  clean  up some deprecations (mne-tools#12067)
  Allow not dropping bads when creating or plotting Spectrum objs (mne-tools#12006)
  Collapsible html repr for raw/info (mne-tools#12064)
  BUG: Fix bug with pickling MNEBadsList (mne-tools#12063)
  add details for Denis (mne-tools#12065)
  ...
@larsoner larsoner mentioned this pull request Nov 6, 2023
Closed
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
@drammock @snwnde
add unicode roundtrip for FIF (mne-tools#12080)
0aae1f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@larsoner larsoner larsoner approved these changes

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations do not support Unicode characters during I/O roundtrip
4 participants
@drammock @hoechenberger @agramfort @larsoner