Add Serialize/Deserialize to TargetInfo
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
github-actions
bot
added
size/M
nick-mobilecoin
force-pushed
the
nick/serialize-types
branch
from
3e595ed to
b4c2437
Compare
nick-mobilecoin
commented
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 87.73% 87.82% +0.09%
==========================================
Files 40 40
Lines 5414 5456 +42
==========================================
+ Hits 4750 4792 +42
Misses 664 664
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
force-pushed
the
nick/serialize-types
branch
from
b4c2437 to
ba4f5e8
Compare
The `TargetInfo` type is used to go to/from an enclave from the untrusted application, so it needs to support serialization.
nick-mobilecoin
force-pushed
the
nick/serialize-types
branch
from
ba4f5e8 to
1cfffa1
Compare
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
This was referenced Jul 18, 2023
eranrund
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TargetInfotype is used to go to/from an enclave from theuntrusted application, so it needs to support serialization.
Future Work
Serializing for
Quote3andReporttypes.