Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add De/Serialize to Report #366

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add De/Serialize to Report #366

merged 1 commit into from
Jul 18, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 18, 2023

The Report type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.

The `Report` type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@meowblecoinbot meowblecoinbot requested a review from a team July 18, 2023 16:23
@github-actions github-actions bot added the size/M PRs with less than 250 lines of changes label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #366 (1784b5a) into nick/serialize-types (1cfffa1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           nick/serialize-types     #366      +/-   ##
========================================================
+ Coverage                 87.82%   87.86%   +0.04%     
========================================================
  Files                        40       40              
  Lines                      5456     5474      +18     
========================================================
+ Hits                       4792     4810      +18     
  Misses                      664      664              
Impacted Files Coverage Δ
core/sys/types/src/lib.rs 100.00% <100.00%> (ø)
core/types/src/report.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 18, 2023 16:30
Base automatically changed from nick/serialize-types to main July 18, 2023 21:20
@nick-mobilecoin nick-mobilecoin merged commit 447728a into main Jul 18, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/serialize-report branch July 18, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M PRs with less than 250 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants