Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add De/Serialize for Qoute3 #367

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add De/Serialize for Qoute3 #367

merged 1 commit into from
Jul 18, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 18, 2023

The Quote3 type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.

@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@meowblecoinbot meowblecoinbot requested a review from a team July 18, 2023 19:56
@github-actions github-actions bot added size/M PRs with less than 250 lines of changes dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jul 18, 2023
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 18, 2023 19:59
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #367 (6514f06) into main (447728a) will increase coverage by 0.12%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   87.86%   87.99%   +0.12%     
==========================================
  Files          40       40              
  Lines        5474     5508      +34     
==========================================
+ Hits         4810     4847      +37     
+ Misses        664      661       -3     
Impacted Files Coverage Δ
dcap/types/src/quote3.rs 97.04% <91.17%> (+0.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from nick/serialize-report to main July 18, 2023 21:20
@nick-mobilecoin nick-mobilecoin force-pushed the nick/serialize-quote3 branch from 6032928 to 857c92c Compare July 18, 2023 21:21
The `Quote3` type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code size/M PRs with less than 250 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants