Feature/transaction signer service #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sign now returns a TxProposal
cbeck88
approved these changes
May 21, 2022
isis-mc
reviewed
May 25, 2022
There was a problem hiding this comment.
Hi! I know this is already merged but I started reviewing last week and only just got to finishing. This looks good to me, and thanks for doing this work. My only vague question was about a test that got commented out but not removed or marked at should fail.
| // use diesel_migrations::{revert_latest_migration, run_pending_migrations}; | ||
| // use mc_account_keys::{AccountKey, PublicAddress}; | ||
| // use mc_common::logger::{test_with_logger, Logger}; | ||
| // use rand::{rngs::StdRng, SeedableRng}; |
There was a problem hiding this comment.
Why are we commenting out this migration test?
briancorbin
added a commit
that referenced
this pull request
Jun 2, 2022
* Latest migration tester (#281) * feature/limit offset optional (#283) * feature/update-ci-testing (#285) * Feature/switch-to-github-actions (#289) * Implement view-key management through CLI. (#290) * Make .mobconf and rust-toolchain reference mobilecoin submodule (#318) * Max Spendable MOB (#314) * Feature/transaction signer service (#282) * Add faq with precision (#324) * Add change output for zero change (#323) * Updating export VO package for normal accounts (#327) * Docs/fix new updates (#330) * Feature/vo account balance improvements (#328) * e2e tests for view only account flow + documentation updates (#333) * fixed bug (#334)
briancorbin
added a commit
that referenced
this pull request
Jun 13, 2022
* Latest migration tester (#281) * feature/limit offset optional (#283) * feature/update-ci-testing (#285) * Feature/switch-to-github-actions (#289) * Implement view-key management through CLI. (#290) * Make .mobconf and rust-toolchain reference mobilecoin submodule (#318) * Max Spendable MOB (#314) * Feature/transaction signer service (#282) * Add faq with precision (#324) * Add change output for zero change (#323) * Updating export VO package for normal accounts (#327) * Docs/fix new updates (#330) * Feature/vo account balance improvements (#328) * e2e tests for view only account flow + documentation updates (#333) * fixed bug (#334) * Implement offline transaction signing in CLI. (#337) * updating gitignore (#341) * Add inputn and output validation (#340) * new release action (#344) * Update actions to include ARM64 build (M1 Mac) (#351) * setting db encryption key earlier (#353) * Fix linker errors related to openssl on Ubuntu 22.04. (#355) * Support BlockVersion 0->2 and mc v1.2.0 (#291) * Upgrade mobilecoin submodule to release 1.2.1. (#357) * only log tx when Token is MOB (#358) * Update cargo lock for mc v1.2.1 (#360) * Get TxLogs by range of blocks (#362) * setting flags for runners for OpenSSL (#364) * Fix build issue with macOS runners (#365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather large PR that includes changes to:
Motivation
This is intended to be an intermediary solution for users that wish to be able to sign transactions without requiring the ledger in the cold-wallet offline flow.
Future Work
A further refactor of the transaction signer alongside potential changes to the TransactionBuilder in the mobilecoin library.