Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Spendable MOB #314

Merged
merged 8 commits into from
May 20, 2022
Merged

Max Spendable MOB #314

merged 8 commits into from
May 20, 2022

Conversation

Shramp
Copy link
Contributor

@Shramp Shramp commented May 17, 2022

Motivation

  • Give users insight into the max amount of MOB they can spend in a single transaction

In this PR

  • Bit of refactoring to create list_spendable txos method that returns the maximum spendable mount in picomob a list of unspend txos
  • Add new field to Balance object + json response that includes max_spendable picomob. Uses new list_spendable method.
  • Use list_spendable method to find spendable txos for transaction building via select_unspent_txos_for_value

Tickets:
#294
#295

Copy link
Contributor

@briancorbin briancorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, going to take one more look over in the morning and we can get this merged :) thank you!

@briancorbin briancorbin requested a review from david1alvarez May 19, 2022 16:48
Copy link
Contributor

@briancorbin briancorbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved once docs are updated :) Thank you!

@briancorbin briancorbin merged commit 730c34c into develop May 20, 2022
@briancorbin briancorbin deleted the feature/max-spendable-mob branch May 20, 2022 20:36
briancorbin added a commit that referenced this pull request Jun 2, 2022
* Latest migration tester (#281)

* feature/limit offset optional (#283)

* feature/update-ci-testing (#285)

* Feature/switch-to-github-actions (#289)

* Implement view-key management through CLI. (#290)

* Make .mobconf and rust-toolchain reference mobilecoin submodule (#318)

* Max Spendable MOB (#314)

* Feature/transaction signer service (#282)

* Add faq with precision (#324)

* Add change output for zero change (#323)

* Updating export VO package for normal accounts (#327)

* Docs/fix new updates (#330)

* Feature/vo account balance improvements (#328)

* e2e tests for view only account flow + documentation updates (#333)

* fixed bug (#334)
briancorbin added a commit that referenced this pull request Jun 13, 2022
* Latest migration tester (#281)

* feature/limit offset optional (#283)

* feature/update-ci-testing (#285)

* Feature/switch-to-github-actions (#289)

* Implement view-key management through CLI. (#290)

* Make .mobconf and rust-toolchain reference mobilecoin submodule (#318)

* Max Spendable MOB (#314)

* Feature/transaction signer service (#282)

* Add faq with precision (#324)

* Add change output for zero change (#323)

* Updating export VO package for normal accounts (#327)

* Docs/fix new updates (#330)

* Feature/vo account balance improvements (#328)

* e2e tests for view only account flow + documentation updates (#333)

* fixed bug (#334)

* Implement offline transaction signing in CLI. (#337)

* updating gitignore (#341)

* Add inputn and output validation (#340)

* new release action (#344)

* Update actions to include ARM64 build (M1 Mac) (#351)

* setting db encryption key earlier (#353)

* Fix linker errors related to openssl on Ubuntu 22.04. (#355)

* Support BlockVersion 0->2 and mc v1.2.0 (#291)

* Upgrade mobilecoin submodule to release 1.2.1. (#357)

* only log tx when Token is MOB (#358)

* Update cargo lock for mc v1.2.1 (#360)

* Get TxLogs by range of blocks (#362)

* setting flags for runners for OpenSSL (#364)

* Fix build issue with macOS runners (#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants