Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .mobconf and rust-toolchain reference mobilecoin submodule #318

Merged
merged 2 commits into from
May 18, 2022

Conversation

remoun
Copy link
Contributor

@remoun remoun commented May 18, 2022

This makes full-service follow whatever versions are in the mobilecoin submodule, i.e. fewer references to update when upgrading the rust-toolchain or builder-install image. Updates can then be propagated when updating the submodule.

@remoun remoun requested review from briancorbin and sugargoat May 18, 2022 19:27
@remoun remoun self-assigned this May 18, 2022
@remoun remoun changed the title Make .mobconf and rust-toolchain symlinks into mobilecoin submodule Make .mobconf and rust-toolchain reference mobilecoin submodule May 18, 2022
@remoun remoun removed the request for review from sugargoat May 18, 2022 19:33
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@briancorbin briancorbin merged commit a2ab624 into develop May 18, 2022
@briancorbin briancorbin deleted the update-CI-image branch May 18, 2022 22:33
briancorbin added a commit that referenced this pull request Jun 2, 2022
* Latest migration tester (#281)

* feature/limit offset optional (#283)

* feature/update-ci-testing (#285)

* Feature/switch-to-github-actions (#289)

* Implement view-key management through CLI. (#290)

* Make .mobconf and rust-toolchain reference mobilecoin submodule (#318)

* Max Spendable MOB (#314)

* Feature/transaction signer service (#282)

* Add faq with precision (#324)

* Add change output for zero change (#323)

* Updating export VO package for normal accounts (#327)

* Docs/fix new updates (#330)

* Feature/vo account balance improvements (#328)

* e2e tests for view only account flow + documentation updates (#333)

* fixed bug (#334)
briancorbin added a commit that referenced this pull request Jun 13, 2022
* Latest migration tester (#281)

* feature/limit offset optional (#283)

* feature/update-ci-testing (#285)

* Feature/switch-to-github-actions (#289)

* Implement view-key management through CLI. (#290)

* Make .mobconf and rust-toolchain reference mobilecoin submodule (#318)

* Max Spendable MOB (#314)

* Feature/transaction signer service (#282)

* Add faq with precision (#324)

* Add change output for zero change (#323)

* Updating export VO package for normal accounts (#327)

* Docs/fix new updates (#330)

* Feature/vo account balance improvements (#328)

* e2e tests for view only account flow + documentation updates (#333)

* fixed bug (#334)

* Implement offline transaction signing in CLI. (#337)

* updating gitignore (#341)

* Add inputn and output validation (#340)

* new release action (#344)

* Update actions to include ARM64 build (M1 Mac) (#351)

* setting db encryption key earlier (#353)

* Fix linker errors related to openssl on Ubuntu 22.04. (#355)

* Support BlockVersion 0->2 and mc v1.2.0 (#291)

* Upgrade mobilecoin submodule to release 1.2.1. (#357)

* only log tx when Token is MOB (#358)

* Update cargo lock for mc v1.2.1 (#360)

* Get TxLogs by range of blocks (#362)

* setting flags for runners for OpenSSL (#364)

* Fix build issue with macOS runners (#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants