Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Relay Data Verifier Precompile in Moonriver and Moonbeam #2729

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

ahmadkaouk
Copy link
Contributor

@ahmadkaouk ahmadkaouk commented Mar 28, 2024

What does it do?

This PR adds the Relay Data Verifier precompile to Moonriver and Moonbeam.

What important points reviewers should know?

The precompile requires adding the relay-storage-roots and precompile-benchmarks also to moonriver and moonbeam.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@ahmadkaouk ahmadkaouk self-assigned this Apr 2, 2024
@ahmadkaouk ahmadkaouk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes labels Apr 2, 2024
@ahmadkaouk ahmadkaouk marked this pull request as ready for review April 2, 2024 11:16
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Coverage Report

@@                      Coverage Diff                       @@
##           master   ahmad-enable-relay-verifier     +/-   ##
==============================================================
  Coverage   72.49%                        72.49%   0.00%     
  Files         229                           229             
+ Lines       70489                         70653    +164     
==============================================================
+ Hits        51094                         51219    +125     
+ Misses      19395                         19434     +39     
Files Changed Coverage
/pallets/asset-manager/src/lib.rs 76.26% (+3.14%) 🔼
/pallets/asset-manager/src/tests.rs 99.79% (+0.03%) 🔼

Coverage generated Wed Apr 3 14:38:36 UTC 2024

@ahmadkaouk ahmadkaouk merged commit e9c386b into master Apr 8, 2024
27 checks passed
@ahmadkaouk ahmadkaouk deleted the ahmad-enable-relay-verifier branch April 8, 2024 09:15
noandrea pushed a commit that referenced this pull request Apr 10, 2024
* add relay-storage-roots pallet to moonriver and moonbeam

* add tests

* Add relay-verifier precompile to moonriver and moonbeam runtimes

* add pallet precompile-benchmarks to moonriver and moonbeam

* set MaxStorageRoots to 30

* fix coverage
noandrea added a commit that referenced this pull request Apr 11, 2024
* Add benchmarks for runtime 2900

* Benchmarks secound run

for commit 36e17c7

* update rust tests accounting for new benches

* Enable Relay Data Verifier Precompile  in Moonriver and Moonbeam (#2729)

* add relay-storage-roots pallet to moonriver and moonbeam

* add tests

* Add relay-verifier precompile to moonriver and moonbeam runtimes

* add pallet precompile-benchmarks to moonriver and moonbeam

* set MaxStorageRoots to 30

* fix coverage

* Update owner of s3 upload action (#2741)

* Update owner of s3 upload action

* Using v1.0.0 instead of master

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>

* add codeowners (#2740)

* add codeowners

* add github tools scripts to codeowners

github tools are used with github actions

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>

* Improve release related content (#2743)

* add Moonkit to the diff in the release page body

* fix docker image tag in client release issu body

* Add Storage Cleaner Precompile (#2725)

* Add precompile to moonbase runtime

* bump precompile-utils version to avoid conflict

* update precompile

* add typescript tests

* update frontier pin

* Fix typescirpt test

* Update callable for precompile

Co-authored-by: Éloïs <c@elo.tf>

* fix format

---------

Co-authored-by: Éloïs <c@elo.tf>

* Fix benchmarks (#2733)

* fix pallet_treasury benchmarks

* fix parachain-staking benchmarks

* update frontier (#2738)

* Fix benchmarks (#2746)

* fix pallet_identity benchmarks

* removed unused moonbeam_xcm_benchmarks::weights::generic benchmarks

* update benchmarks (take 3)

* fix rust tests

* update limits for rewards limits

* increase refTime limt for block rewards distribution

---------

Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
Co-authored-by: Mario Sánchez García <66425016+mario-sangar@users.noreply.github.com>
Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>
Co-authored-by: Éloïs <c@elo.tf>
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants