Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codeowners #2740

Merged
merged 3 commits into from
Apr 8, 2024
Merged

add codeowners #2740

merged 3 commits into from
Apr 8, 2024

Conversation

noandrea
Copy link
Collaborator

@noandrea noandrea commented Apr 5, 2024

What does it do?

Add CODEOWNERS requiring specific approvals for the following folders

  • .github
  • tools/github

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@noandrea noandrea added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Apr 5, 2024
@noandrea noandrea marked this pull request as ready for review April 5, 2024 20:19
noandrea and others added 2 commits April 8, 2024 10:38
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Coverage Report

@@                  Coverage Diff                   @@
##           master   noandrea-codeowners     +/-   ##
======================================================
  Coverage   72.46%                72.46%   0.00%     
  Files         229                   229             
  Lines       70512                 70512             
======================================================
  Hits        51094                 51094             
  Misses      19418                 19418             
Files Changed Coverage

Coverage generated Mon Apr 8 10:07:34 UTC 2024

@noandrea noandrea merged commit a2f9692 into master Apr 8, 2024
27 checks passed
@noandrea noandrea deleted the noandrea-codeowners branch April 8, 2024 10:28
noandrea added a commit that referenced this pull request Apr 10, 2024
* add codeowners

* add github tools scripts to codeowners

github tools are used with github actions

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>
noandrea added a commit that referenced this pull request Apr 11, 2024
* Add benchmarks for runtime 2900

* Benchmarks secound run

for commit 36e17c7

* update rust tests accounting for new benches

* Enable Relay Data Verifier Precompile  in Moonriver and Moonbeam (#2729)

* add relay-storage-roots pallet to moonriver and moonbeam

* add tests

* Add relay-verifier precompile to moonriver and moonbeam runtimes

* add pallet precompile-benchmarks to moonriver and moonbeam

* set MaxStorageRoots to 30

* fix coverage

* Update owner of s3 upload action (#2741)

* Update owner of s3 upload action

* Using v1.0.0 instead of master

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>

* add codeowners (#2740)

* add codeowners

* add github tools scripts to codeowners

github tools are used with github actions

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>

* Improve release related content (#2743)

* add Moonkit to the diff in the release page body

* fix docker image tag in client release issu body

* Add Storage Cleaner Precompile (#2725)

* Add precompile to moonbase runtime

* bump precompile-utils version to avoid conflict

* update precompile

* add typescript tests

* update frontier pin

* Fix typescirpt test

* Update callable for precompile

Co-authored-by: Éloïs <c@elo.tf>

* fix format

---------

Co-authored-by: Éloïs <c@elo.tf>

* Fix benchmarks (#2733)

* fix pallet_treasury benchmarks

* fix parachain-staking benchmarks

* update frontier (#2738)

* Fix benchmarks (#2746)

* fix pallet_identity benchmarks

* removed unused moonbeam_xcm_benchmarks::weights::generic benchmarks

* update benchmarks (take 3)

* fix rust tests

* update limits for rewards limits

* increase refTime limt for block rewards distribution

---------

Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
Co-authored-by: Mario Sánchez García <66425016+mario-sangar@users.noreply.github.com>
Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>
Co-authored-by: Éloïs <c@elo.tf>
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants