Ignore user provided nonce for gas estimation #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
Coverage Report@@ Coverage Diff @@
## master elois-estimate-gas-ignore-nonce +/- ##
==================================================================
Coverage 72.46% 72.46% 0.00%
Files 229 229
Lines 70512 70512
==================================================================
Hits 51094 51094
Misses 19418 19418
|
|
Are we going to suggest those changes upstream? @librelois |
librelois
force-pushed
the
elois-estimate-gas-ignore-nonce
branch
from
eb180d0
to
42b4f01
Compare
It make sense to do that yes |
RomarQ
approved these changes
Apr 9, 2024
ahmadkaouk
approved these changes
Apr 9, 2024
noandrea
pushed a commit
that referenced
this pull request
Apr 10, 2024
noandrea
added a commit
that referenced
this pull request
Apr 11, 2024
* Add benchmarks for runtime 2900 * Benchmarks secound run for commit 36e17c7 * update rust tests accounting for new benches * Enable Relay Data Verifier Precompile in Moonriver and Moonbeam (#2729) * add relay-storage-roots pallet to moonriver and moonbeam * add tests * Add relay-verifier precompile to moonriver and moonbeam runtimes * add pallet precompile-benchmarks to moonriver and moonbeam * set MaxStorageRoots to 30 * fix coverage * Update owner of s3 upload action (#2741) * Update owner of s3 upload action * Using v1.0.0 instead of master --------- Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> * add codeowners (#2740) * add codeowners * add github tools scripts to codeowners github tools are used with github actions --------- Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> * Improve release related content (#2743) * add Moonkit to the diff in the release page body * fix docker image tag in client release issu body * Add Storage Cleaner Precompile (#2725) * Add precompile to moonbase runtime * bump precompile-utils version to avoid conflict * update precompile * add typescript tests * update frontier pin * Fix typescirpt test * Update callable for precompile Co-authored-by: Éloïs <c@elo.tf> * fix format --------- Co-authored-by: Éloïs <c@elo.tf> * Fix benchmarks (#2733) * fix pallet_treasury benchmarks * fix parachain-staking benchmarks * update frontier (#2738) * Fix benchmarks (#2746) * fix pallet_identity benchmarks * removed unused moonbeam_xcm_benchmarks::weights::generic benchmarks * update benchmarks (take 3) * fix rust tests * update limits for rewards limits * increase refTime limt for block rewards distribution --------- Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com> Co-authored-by: Mario Sánchez García <66425016+mario-sangar@users.noreply.github.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: Éloïs <c@elo.tf> Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The RPC method
ets_estimageGastake a Transaction object with a nonce field, moonbeam client require that this nonce is equal to the current on)-chain user nonce + 1.It's a discrepency with geth behavior, geth always ignore the nonce field (the field is still there to not break the RPC api but not used).
This PR always set the nonce to None inside the estimage_gas function body.
The change is in frontier: moonbeam-foundation/frontier@101e61f
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?