-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TimeParameterization classes polymorphic #1012
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
+ Coverage 57.93% 57.94% +0.02%
==========================================
Files 309 312 +3
Lines 26119 26121 +2
==========================================
+ Hits 15130 15134 +4
+ Misses 10989 10987 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this too urgent so that we can't wait for this to get synced? Good change, imo
@@ -0,0 +1,18 @@ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license header?
{ | ||
public: | ||
virtual ~TimeParameterization() = default; | ||
virtual bool computeTimeStamps(robot_trajectory::RobotTrajectory& trajectory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good opportunity to add documentation to the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I can actually block merging on my own but I'm marking this as "request changes" until there are comments. Otherwise it's too easy to forget them :)
Replace with #1151 |
Description
Cherry-pick moveit/moveit#3021 in moveit2
Checklist