Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TimeParameterization classes polymorphic #1012

Closed
wants to merge 3 commits into from

Conversation

JafarAbdi
Copy link
Member

Description

Cherry-pick moveit/moveit#3021 in moveit2

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1012 (73145df) into main (4e65a4f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
+ Coverage   57.93%   57.94%   +0.02%     
==========================================
  Files         309      312       +3     
  Lines       26119    26121       +2     
==========================================
+ Hits        15130    15134       +4     
+ Misses      10989    10987       -2     
Impacted Files Coverage Δ
...ry_processing/time_optimal_trajectory_generation.h 100.00% <ø> (ø)
...cessing/src/time_optimal_trajectory_generation.cpp 77.80% <ø> (+0.31%) ⬆️
...ory_processing/iterative_spline_parameterization.h 100.00% <100.00%> (ø)
...ctory_processing/iterative_time_parameterization.h 100.00% <100.00%> (ø)
...veit/trajectory_processing/time_parameterization.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e65a4f...73145df. Read the comment docs.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too urgent so that we can't wait for this to get synced? Good change, imo

@@ -0,0 +1,18 @@
#pragma once
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license header?

{
public:
virtual ~TimeParameterization() = default;
virtual bool computeTimeStamps(robot_trajectory::RobotTrajectory& trajectory,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good opportunity to add documentation to the interface.

Copy link
Contributor

@jliukkonen jliukkonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I can actually block merging on my own but I'm marking this as "request changes" until there are comments. Otherwise it's too easy to forget them :)

@JafarAbdi
Copy link
Member Author

Replace with #1151

@JafarAbdi JafarAbdi closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants