Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy] Latched Strings for URDF and SRDF #1414

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Jul 1, 2022

Description

#765 for foxy (with a little bit of #1050 and #1132)

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@DLu DLu requested a review from tylerjw July 1, 2022 16:06
@mergify
Copy link

mergify bot commented Jul 1, 2022

Please target the main branch for development, we will backport the changes to foxy for you if approved and if they don't break API.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1414 (6c3e7e7) into foxy (949face) will increase coverage by 0.29%.
The diff coverage is 72.73%.

@@            Coverage Diff             @@
##             foxy    #1414      +/-   ##
==========================================
+ Coverage   46.79%   47.08%   +0.29%     
==========================================
  Files         185      187       +2     
  Lines       19693    19749      +56     
==========================================
+ Hits         9214     9297      +83     
+ Misses      10479    10452      -27     
Impacted Files Coverage Δ
.../rdf_loader/include/moveit/rdf_loader/rdf_loader.h 66.67% <0.00%> (+66.67%) ⬆️
moveit_ros/planning/rdf_loader/src/rdf_loader.cpp 52.69% <55.27%> (+31.04%) ⬆️
...g/rdf_loader/src/synchronized_string_parameter.cpp 84.75% <84.75%> (ø)
.../moveit/rdf_loader/synchronized_string_parameter.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949face...6c3e7e7. Read the comment docs.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the changes except that we are changing API here. I would like to make sure @henningkayser @JafarAbdi @tylerjw or any other maintainers are OK with this as well.

@vatanaksoytezer
Copy link
Contributor

Ping to @tylerjw and @henningkayser

@tylerjw tylerjw merged commit 4bddaa0 into moveit:foxy Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants