Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foxy] Port MoveItConfigsBuilder #1450

Closed
wants to merge 3 commits into from
Closed

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Jul 27, 2022

Description

Part of #1449

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Create tests, which fail without this PR reference

@mergify
Copy link

mergify bot commented Jul 27, 2022

Please target the main branch for development, we will backport the changes to foxy for you if approved and if they don't break API.

@vatanaksoytezer
Copy link
Contributor

@DLu
Copy link
Contributor Author

DLu commented Jul 28, 2022

@DLu Don't we need launches.py as well in moveit_configs_utils: https://github.com/ros-planning/moveit2/blob/main/moveit_configs_utils/moveit_configs_utils/launches.py

Eventually we will, but I was planning on doing that in future PRs as I adjust them for Foxy.

@DLu
Copy link
Contributor Author

DLu commented Jul 28, 2022

Tests are failing because moveit_resources is behind on the Foxy branch compared to main. (2.0.6 vs 2.0.3)

@vatanaksoytezer
Copy link
Contributor

I think there were some breaking changes, which made us make a foxy branch. Do you think we can add necessary files to foxy branch of moveit_resource or arrange tests?

@sjahr
Copy link
Contributor

sjahr commented Aug 1, 2023

Closing this since foxy EOL

@sjahr sjahr closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants