Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cartesian interpolation #3020

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Oct 6, 2024

This is a follow-up on #2916, fixing a bug reported in moveit/moveit#3651.

@sea-bass
Copy link
Contributor

The build failure on Rolling here looks quite strange... also seemingly unrelated to this PR. Could this be a build caching thing?

@rhaschke
Copy link
Contributor Author

rhaschke commented Oct 13, 2024

The build failure on Rolling here looks quite strange... also seemingly unrelated to this PR. Could this be a build caching thing?

I had similar issues in #3003, which were fixed by deleting the upstream cache. However, here, the caches were not found anyway. So, I'm not yet sure why this fails for one rolling build but not the other.
It's definitely unrelated to the PR.

Edit: The issue also occurs on the main branch and in other PRs - since #3024 was merged: https://github.com/moveit/moveit2/actions/runs/11313105568/job/31461458873

I'm looking into possible reasons.

@rhaschke
Copy link
Contributor Author

libsrdfdom doesn't link against tinyxml2:

ldd /opt/ros/rolling/lib/libsrdfdom.so.2.0.4
	linux-vdso.so.1 (0x00007ffd7d343000)
	libconsole_bridge.so.1.0 => /lib/x86_64-linux-gnu/libconsole_bridge.so.1.0 (0x000071a3689a5000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x000071a368728000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x000071a3686fb000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x000071a3684e9000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x000071a368400000)

Probably this wasn't noticed before, because the plugins (removed in #3024) pulled in this dependency.

@rhaschke rhaschke mentioned this pull request Oct 13, 2024
@rhaschke rhaschke force-pushed the fix-cartesian-interpolation branch from ac09e67 to f350174 Compare October 13, 2024 22:18
@rhaschke
Copy link
Contributor Author

rhaschke commented Oct 13, 2024

I have no idea why this PR still fails (for an unrelated reason), while the main branch works again.
srdfdom/model.h should be missing in both or none case.

Edit: The reason is that srdfdom is still broken. The includes are not found anymore.
The problem didn't show up on the main branch, because that was still accessing headers in /opt/ros.
The docker source build fails: https://github.com/moveit/moveit2/actions/runs/11317019415

Edit: I think I fixed srdfdom: moveit/srdfdom@65ce909

@rhaschke rhaschke enabled auto-merge October 14, 2024 06:06
@sjahr sjahr disabled auto-merge October 14, 2024 06:23
@sjahr sjahr merged commit f92f443 into moveit:main Oct 14, 2024
10 of 13 checks passed
@rhaschke rhaschke deleted the fix-cartesian-interpolation branch October 14, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants