Remove plugins from export set #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
|
Looks like a servo test failed. Is it flaky? |
Yes. #3005 ... I couldn't figure out why after many attempts. |
|
Not a blocker for this PR, just waited for CI to pass to be sure this PR doesn't introduce new issues 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think the plugin that are intended to be loaded by classloader or pluginlib should not be exported as the same exportset as the libraries that are intended to be dynamically linked. I ran into an issue where
libmoveit_ompl_planner_plugin.sois being dynamically linked tolibmoveit_default_planning_response_adapter_plugins.so, which breaksMultiLibraryClassLoader.