Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepts all incoming changes. #3120

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Accepts all incoming changes. #3120

merged 1 commit into from
Nov 21, 2024

Conversation

rr-mark
Copy link

@rr-mark rr-mark commented Nov 21, 2024

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify Mergify
Copy link

mergify bot commented Nov 21, 2024

Please target the main branch for development, we will backport the changes to mergify/bp/humble/pr-3041 for you if approved and if they don't break API.

@rr-mark rr-mark mentioned this pull request Nov 21, 2024
Closed
@sea-bass sea-bass merged commit 0ae12dd into moveit:mergify/bp/humble/pr-3041 Nov 21, 2024
2 checks passed
sea-bass pushed a commit that referenced this pull request Nov 21, 2024
@mergify @TSNoble @rr-mark
Enhancement/moveit ros1 ports (backport #3041) (#3118)
172c128 
* Enhancement/moveit ros1 ports (#3041)

* Ports moveit/moveit#3592

* Ports moveit/moveit#3590

* Fixes compile errors

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit 02ebcba)

# Conflicts:
#	moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp

* Accepts all incoming changes. (#3120)

* Fixes member names (#3121)

---------

Co-authored-by: Tom Noble <53005340+TSNoble@users.noreply.github.com>
Co-authored-by: Mark Johnson <104826595+rr-mark@users.noreply.github.com>
Co-authored-by: Tom Noble <t.s.noble@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rr-mark @sea-bass