-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/moveit ros1 ports #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting this over @TSNoble! Looks like there are still some build failures but that should be easy to address and once that is done, we can merge this!
@sjahr Thanks for running the workflows again. I'm unsure if the test failures are related to this PR? |
Retriggered the Jazzy CI since the failure appears to be unrelated to this PR |
* Ports moveit/moveit#3592 * Ports moveit/moveit#3590 * Fixes compile errors --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit 02ebcba) # Conflicts: # moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp
* Enhancement/moveit ros1 ports (#3041) * Ports moveit/moveit#3592 * Ports moveit/moveit#3590 * Fixes compile errors --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit 02ebcba) # Conflicts: # moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp * Accepts all incoming changes. (#3120) * Fixes member names (#3121) --------- Co-authored-by: Tom Noble <53005340+TSNoble@users.noreply.github.com> Co-authored-by: Mark Johnson <104826595+rr-mark@users.noreply.github.com> Co-authored-by: Tom Noble <t.s.noble@outlook.com>
Description
This PR ports the following ROS1 PRs to moveit2:
More in-depth descriptions can be found on those pull requests, however, for summary:
Modifies
MoveGroupInterace
to use amoveit_msgs::msgs::RobotSate
as theconsidered_start_state_
RobotState
diffs to avoid passing around large messagesrobot_state::RobotStatePtr
to avoid breaking changesDisables updating of attached collision objects when updating states during a pilz sequence motion
I've more-or-less copied the changes from those PRs in verbatim, so if there are differences in moveit2 that need to be taken into account, let me know and I'll make them.
Checklist