Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes member names #3121

Merged

Conversation

TSNoble
Copy link
Contributor

@TSNoble TSNoble commented Nov 21, 2024

No description provided.

Copy link

mergify bot commented Nov 21, 2024

Please target the main branch for development, we will backport the changes to mergify/bp/humble/pr-3041 for you if approved and if they don't break API.

@sea-bass sea-bass merged commit 5f755d7 into moveit:mergify/bp/humble/pr-3041 Nov 21, 2024
6 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.26%. Comparing base (0ae12dd) to head (3dc22f0).
Report is 1 commits behind head on mergify/bp/humble/pr-3041.

Files with missing lines Patch % Lines
.../move_group_interface/src/move_group_interface.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           mergify/bp/humble/pr-3041    #3121       +/-   ##
==============================================================
+ Coverage                       0.00%   42.26%   +42.26%     
==============================================================
  Files                            395      668      +273     
  Lines                          37271    57740    +20469     
  Branches                        5304     7322     +2018     
==============================================================
+ Hits                               0    24399    +24399     
+ Misses                         37271    33155     -4116     
- Partials                           0      186      +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

sea-bass pushed a commit that referenced this pull request Nov 21, 2024
* Enhancement/moveit ros1 ports (#3041)

* Ports moveit/moveit#3592

* Ports moveit/moveit#3590

* Fixes compile errors

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit 02ebcba)

# Conflicts:
#	moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp

* Accepts all incoming changes. (#3120)

* Fixes member names (#3121)

---------

Co-authored-by: Tom Noble <53005340+TSNoble@users.noreply.github.com>
Co-authored-by: Mark Johnson <104826595+rr-mark@users.noreply.github.com>
Co-authored-by: Tom Noble <t.s.noble@outlook.com>
@TSNoble TSNoble deleted the mergify/bp/humble/pr-3041 branch November 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants