-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ! in place of not keyword for Pilz and CHOMP planners #3217
Conversation
Thanks! I replaced another usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -- thank you!
Fixing the PR title then we can merge
Thanks for the super-fast feedback! |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
+ Coverage 45.64% 45.65% +0.01%
==========================================
Files 714 714
Lines 62297 62299 +2
Branches 7529 7530 +1
==========================================
+ Hits 28432 28436 +4
+ Misses 33699 33696 -3
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com> (cherry picked from commit 549a2ee)
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com> (cherry picked from commit 549a2ee)
Description
While compiling this package on Windows (see RoboStack/ros-humble#241), the Windows compilation was failing as depending on the compilation options
not
may not be supported in MSVC depending on the compilation options.Anyhow, as everywhere else in the code
!
is used, I think it make sense to be consistent and use!
also here.Checklist