Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ! in place of not keyword for Pilz and CHOMP planners #3217

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 9, 2025

Description

While compiling this package on Windows (see RoboStack/ros-humble#241), the Windows compilation was failing as depending on the compilation options not may not be supported in MSVC depending on the compilation options.

Anyhow, as everywhere else in the code ! is used, I think it make sense to be consistent and use ! also here.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@JafarAbdi
Copy link
Member

JafarAbdi commented Jan 9, 2025

Thanks! I replaced another usage of not in chomp_planner as well!

@sea-bass sea-bass added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Jan 9, 2025
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- thank you!

Fixing the PR title then we can merge

@sea-bass sea-bass changed the title pilz_industrial_motion_planner: Use ! in place of not keyword for conpilz_industrial_motion_planner Use ! in place of not keyword for pilz_industrial_motion_planner and chomp_planner Jan 9, 2025
@sea-bass sea-bass changed the title Use ! in place of not keyword for pilz_industrial_motion_planner and chomp_planner Use ! in place of not keyword for Pilz and CHOMP planners Jan 9, 2025
@sea-bass sea-bass enabled auto-merge January 9, 2025 23:27
@traversaro
Copy link
Contributor Author

Thanks for the super-fast feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (932c192) to head (a6e9213).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/chomp/chomp_motion_planner/src/chomp_planner.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
+ Coverage   45.64%   45.65%   +0.01%     
==========================================
  Files         714      714              
  Lines       62297    62299       +2     
  Branches     7529     7530       +1     
==========================================
+ Hits        28432    28436       +4     
+ Misses      33699    33696       -3     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass added this pull request to the merge queue Jan 10, 2025
Merged via the queue into moveit:main with commit 549a2ee Jan 10, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency

* Use ! in place of not keyword for chomp_planner.cpp

---------

Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
(cherry picked from commit 549a2ee)
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency

* Use ! in place of not keyword for chomp_planner.cpp

---------

Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
(cherry picked from commit 549a2ee)
sea-bass pushed a commit that referenced this pull request Jan 10, 2025
)

Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
(cherry picked from commit 549a2ee)

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
sea-bass pushed a commit that referenced this pull request Jan 10, 2025
)

Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
(cherry picked from commit 549a2ee)

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants