Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ! in place of not keyword for Pilz and CHOMP planners (backport #3217) #3222

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 10, 2025

Description

While compiling this package on Windows (see RoboStack/ros-humble#241), the Windows compilation was failing as depending on the compilation options not may not be supported in MSVC depending on the compilation options.

Anyhow, as everywhere else in the code ! is used, I think it make sense to be consistent and use ! also here.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3217 done by [Mergify](https://mergify.com).

* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency

* Use ! in place of not keyword for chomp_planner.cpp

---------

Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
(cherry picked from commit 549a2ee)
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.19%. Comparing base (f820ea4) to head (74e73b5).
Report is 2 commits behind head on jazzy.

Files with missing lines Patch % Lines
...s/chomp/chomp_motion_planner/src/chomp_planner.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3222      +/-   ##
==========================================
- Coverage   44.19%   44.19%   -0.00%     
==========================================
  Files         698      698              
  Lines       61586    61585       -1     
  Branches     7460     7459       -1     
==========================================
- Hits        27214    27210       -4     
- Misses      34205    34207       +2     
- Partials      167      168       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 1a5d9fc into jazzy Jan 10, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3217 branch January 10, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants