Remove released repos from repos file #975
Conversation
|
Please target the |
| @@ -1,33 +0,0 @@ | |||
| repositories: | |||
There was a problem hiding this comment.
Instead of deleting, I think it's fine keeping an empty or commented file
There was a problem hiding this comment.
Putting it back but commenting it out might cause the docker build to fail. I changed the docker build to test if it exists before running vcs import. I'll test what vcs import does with a all commented out or empty file.
There was a problem hiding this comment.
Commenting out the whole file causes vcs to return non-zero and give this output:
Input data is not valid format: 'NoneType' object is not subscribable
The way I did it here it still returns 0, it just prints this warning:
List of repositories is empty
There was a problem hiding this comment.
It also looks good to me. I agree with Henning that we might want to use .repos in the future, if we want to merge a change depending on our upstream.
tylerjw
force-pushed
the
update_repos_repos
branch
from
495bfdc to
4db7029
Compare
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
tylerjw
force-pushed
the
update_repos_repos
branch
from
4db7029 to
73c9ea8
Compare
Codecov Report
@@ Coverage Diff @@
## foxy #975 +/- ##
==========================================
- Coverage 46.81% 46.79% -0.01%
==========================================
Files 185 185
Lines 19693 19693
==========================================
- Hits 9217 9214 -3
- Misses 10476 10479 +3
Continue to review full report at Codecov.
|
tylerjw
changed the title
Description
The repos file is not needed for foxy. All released versions are acceptable. This PR removes the file and adapts the Dockerfiles to handle it not existing.