Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove attempts field from PositionIKRequest.msg #76

Merged
merged 1 commit into from
May 21, 2020
Merged

remove attempts field from PositionIKRequest.msg #76

merged 1 commit into from
May 21, 2020

Conversation

708yamaguchi
Copy link
Contributor

@708yamaguchi 708yamaguchi commented May 14, 2020 •
edited
Loading

I removed attempts field from PositionIKRequest.msg because attemts field is not used now.
I think this field may be confusing.

Please refer to:
moveit/moveit#1288

v4hn
v4hn approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. We obviously missed that when getting rid of the parameter.

Thanks!

@v4hn v4hn added the awaits 2nd review one maintainer approved this request label May 14, 2020
@rhaschke rhaschke merged commit 82cda0e into moveit:master May 21, 2020
@henningkayser henningkayser mentioned this pull request Jun 8, 2020
Merged
@robberthofmanfm robberthofmanfm mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@v4hn v4hn v4hn approved these changes

Assignees
No one assigned
Labels
awaits 2nd review one maintainer approved this request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@708yamaguchi @v4hn @rhaschke