Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic release #96

Closed
8 of 11 tasks
rhaschke opened this issue Nov 8, 2021 · 19 comments
Closed
8 of 11 tasks

Noetic release #96

rhaschke opened this issue Nov 8, 2021 · 19 comments

Comments

@rhaschke
Copy link
Contributor

rhaschke commented Nov 8, 2021

I reworked (and force-pushed) the noetic-devel branch once more as announced in #89 (comment).

The new branch can be considered a release candidate, but relies on several open PRs in franka_ros (also see frankaemika/franka_ros#193) and MoveIt, namely:

Other open TODOs (@rickstaa, can you work on these?):

@rickstaa

This comment has been minimized.

@rickstaa
Copy link
Contributor

rickstaa commented Nov 11, 2021

The STOMP and OMPL-STOMP planners have been added to MSA in moveit/moveit#2955.

This was referenced Nov 11, 2021
@rickstaa

This comment has been minimized.

@rickstaa
Copy link
Contributor

@rhaschke, I think some of the todos in this issue can be checked as done. For testing the tutorials, I'm waiting for @frankaemika to decide on frankaemika/franka_ros#188 since if I do it now, things change I might have to retest.

@gollth
Copy link
Contributor

gollth commented Feb 2, 2022

Hey there,

I'm testing out the new noetic-devel branch of this repo together with the new MoveIT and ran into some problem:

Suppose I want to start the move group in a launch file like so:

<?xml version="1.0" ?>
<launch>
  <arg name="robot_ip" />

  <arg name="transmission" value="position" />

  <include file="$(find franka_control)/launch/franka_control.launch" pass_all_args="true" />

  <include file="$(find panda_moveit_config)/launch/move_group.launch">
    <arg name="load_gripper" value="true" />
  </include>

</launch>

I get the error message to please set the transmission argument:

included file [/home/franka/ros/src/panda_moveit_config/launch/simple_moveit_controller_manager.launch.xml] requires the 'transmission' arg to be set

However the move_group.launch does not accept such an argument:

RLException: unused args [transmission] for include of [/home/franka/ros/src/panda_moveit_config/launch/move_group.launch]

AFAIR in Melodic you didn't need to (and couldn't) provide an extra "transmission" argument to the move_group.launch.

How is this indented to work now?

@rhaschke
Copy link
Contributor Author

rhaschke commented Feb 2, 2022

In demo.launch it seems to work because we include move_group.launch with pass_all_args="true":
https://github.com/ros-planning/panda_moveit_config/blob/c38a59af4ca94c008b3677e1ee1787a64bc6fea3/launch/demo.launch#L55

There is a working example file very similar to your example: franka_control.launch.

@gollth
Copy link
Contributor

gollth commented Feb 3, 2022

Thanks for the answer, I thought so as well that this is the background. But this would mean that you cannot even use this launch file like this anymore:

<launch>
  <include file="$(find panda_moveit_config)/launch/move_group.launch" />
</launch>

I think many users of this repo will have something similar to this in their user code. Is this breaking change really something you intent? If yes is it already documented somewhere already?

@rhaschke
Copy link
Contributor Author

rhaschke commented Feb 3, 2022

I will try to improve the launch files over the weekend.

@gollth
Copy link
Contributor

gollth commented Mar 9, 2022

Hey @rhaschke any updates on this? Currently panda_moveit_config is in a not very usable state

@rhaschke
Copy link
Contributor Author

rhaschke commented Mar 9, 2022

Sorry, I was busy with many other things. I will try over the coming weekend to catch up on this.
What is your progress on frankaemika/franka_ros#199?
Using the coarse self-collision models for environmental collision checks as well, renders MoveIt very much unusable in general 😉

@rickstaa
Copy link
Contributor

rickstaa commented Aug 9, 2022

I had some questions I my email about how to use the new noetic branch so I will put this here as a reference:

  1. Install ROS noetic (see http://wiki.ros.org/noetic/Installation/Ubuntu).
  2. Build libfranka from source (see https://frankaemika.github.io/docs/installation_linux.html).
  3. Build franka_ros from source (see https://frankaemika.github.io/docs/installation_linux.html).
  4. Clone the noetic branch of panda_moveit_config.
  5. Install the ros dependencies using:
    rosdep install --from-paths src --ignore-src --rosdistro noetic -y --skip-keys libfranka
  6. Build the catkin workspace.
    catkin build -DCMAKE_BUILD_TYPE=Release -DFranka_DIR:PATH=<PATH_TO_LIBFRANKA>/libfranka/build
  7. Run the ros-planning/panda_moveit_config/blob/noetic-devel/launch/demo_gazebo.launch launch file.
  8. Move the robot using the RVIZ Moveit Planning GUI (see video below).
use_noetic_moveit_example.mp4

@rickstaa
Copy link
Contributor

rickstaa commented Aug 9, 2022

@rhaschke @gollth, I don't think anything is blocking us from releasing the noetic package. To my knowledge, the last time I checked, there were only the instabilities in the gripper action (gripper action time out, gripper action not working when the gripper is vertical - see frankaemika/franka_ros#172).

@rhaschke
Copy link
Contributor Author

rhaschke commented Aug 9, 2022

I agree. However, before releasing panda_moveit_config, franka_ros should be released including frankaemika/franka_ros#199, which was merged in April. Also, we will diverge between Melodic and Noetic as MoveIt Melodic doesn't support the new collision matrix specification, i.e. coarse vs. detailed collision models required by franka_description. @gollth, are you fine with this?

@gollth
Copy link
Contributor

gollth commented Aug 29, 2022

Hi @rhaschke,

sorry for the late reply I was on holiday until today.

Sounds good to me. We will release everything currently in develop shortly.

we will diverge between Melodic and Noetic

Seems logical to me.

@gollth
Copy link
Contributor

gollth commented Aug 29, 2022

Just as a heads up, @marcbone is currently working on a URDF changing feature in franka_ros. The outer interface (i.e. XACRO args and filenames ...) will stay the same, but the internal structure will be refactored a bit. We don't think this will be a breaking change for panda_moveit_config but with URDFs you can never know how breaking it really is.

@rhaschke
Copy link
Contributor Author

@marcbone is currently working on a URDF changing feature in franka_ros

Please inform me if this gets merged and I will have a look at panda_moveit_config.

@gollth
Copy link
Contributor

gollth commented Aug 30, 2022

franka_ros 0.9.1 is now released on melodic and noetic

@rhaschke
Copy link
Contributor Author

rhaschke commented Sep 1, 2022

I triggered a release into Noetic: ros/rosdistro#34290
as well as into Melodic: ros/rosdistro#34297

@rhaschke rhaschke closed this as completed Sep 1, 2022
@marcbone
Copy link
Contributor

marcbone commented Sep 5, 2022

@marcbone is currently working on a URDF changing feature in franka_ros

Please inform me if this gets merged and I will have a look at panda_moveit_config.

I guess there was a bit of miscommunication. The refactoring of the URDF is now done and on the develop branch, but it was not part of the0.9.1 release. We will make a release over rosdistro for version 0.10.0 tomorrow.

rickstaa added a commit to rickstaa/panda-gazebo that referenced this issue Nov 23, 2023
This commit removes the 'panda_moveit_config' submodule and replaces it with
a ROS depencency now that the noetic version has been released
(moveit/panda_moveit_config#96).
rickstaa added a commit to rickstaa/panda-gazebo that referenced this issue Nov 23, 2023
This commit removes the 'panda_moveit_config' submodule and replaces it with
a ROS dependency now that the noetic version has been released
(moveit/panda_moveit_config#96).
rickstaa added a commit to rickstaa/panda-gazebo that referenced this issue Nov 23, 2023
This commit removes the 'panda_moveit_config' submodule and replaces it with
a ROS dependency now that the noetic version has been released
(moveit/panda_moveit_config#96).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants