Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #9805 - Add support for opening links from ACTION_MAIN Intents #9811

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Mar 2, 2021

This kind of Intents could get to the app following calls to Intent .makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER).

Recording showing this patch used by Fenix's mozilla-mobile/fenix#18234

OpeningActionMainURLs.mp4

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

…N_MAIN Intents

This kind of Intents could get to the app following calls to `Intent
.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER)`.
@Mugurell Mugurell requested a review from a team as a code owner March 2, 2021 16:05
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #9811 (7b4f4a9) into master (2a893b0) will decrease coverage by 1.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9811      +/-   ##
============================================
- Coverage     74.10%   72.56%   -1.54%     
+ Complexity     5645     1552    -4093     
============================================
  Files           770      254     -516     
  Lines         28717     8213   -20504     
  Branches       4728     1435    -3293     
============================================
- Hits          21281     5960   -15321     
+ Misses         4966     1543    -3423     
+ Partials       2470      710    -1760     
Impacted Files Coverage Δ Complexity Δ
...ts/feature/intent/processing/TabIntentProcessor.kt 71.42% <0.00%> (ø) 20.00 <0.00> (+1.00)
...n/java/mozilla/components/lib/crash/db/CrashDao.kt
...onents/browser/engine/system/matcher/UrlMatcher.kt
...main/java/mozilla/components/lib/jexl/ast/nodes.kt
...components/feature/syncedtabs/SyncedTabsFeature.kt
...ents/browser/toolbar/display/DisplayToolbarView.kt
...omponents/lib/crash/handler/CrashHandlerService.kt
...nts/feature/prompts/dialog/PromptAbuserDetector.kt
...components/feature/prompts/dialog/ChoiceAdapter.kt
...ava/mozilla/components/concept/push/PushService.kt
... and 507 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a893b0...7b4f4a9. Read the comment docs.

@codrut-topliceanu codrut-topliceanu self-requested a review March 3, 2021 13:09
@codrut-topliceanu codrut-topliceanu self-assigned this Mar 3, 2021
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
+Tested on Pixel 3xl

@jonalmeida
Copy link
Contributor

There is a PR for to add this support in Fenix, but this looks like a better intent processor to add ACTION_MAIN support. 🙂

@Mugurell
Copy link
Contributor Author

Mugurell commented Mar 4, 2021

Thank you @jonalmeida and @codrut-topliceanu !
I'm sorry I didn't see the previous work :-(
I'd propose merging this and closing the others when the issue is verified on Fenix.

@Mugurell Mugurell added the 🛬 needs landing PRs that are ready to land label Mar 4, 2021
@mergify mergify bot merged commit 11b88bf into mozilla-mobile:master Mar 4, 2021
@Mugurell Mugurell deleted the 9805ActionMainLinks branch March 4, 2021 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants