Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #17963 - Present Fenix as a browser app to the system #18234

Merged
merged 1 commit into from
Mar 5, 2021
Merged

For #17963 - Present Fenix as a browser app to the system #18234

merged 1 commit into from
Mar 5, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Mar 1, 2021

Fenix will now be able to be started from a call to
Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER)

For more info:
https://developer.android.com/reference/android/content/Intent#CATEGORY_APP_BROWSER

While Fenix will now appear in the list of browsers it still doesn't know open
links coming from ACTION_MAIN Intents. Needs some AC modifications first - mozilla-mobile/android-components#9805

FlipboardOpeningFenix.mp4

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners March 1, 2021 16:25
Fenix will now be able to be started from a call to
Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER)

For more info:
https://developer.android.com/reference/android/content/Intent#CATEGORY_APP_BROWSER
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

@Mugurell Mugurell merged commit 7d2c307 into mozilla-mobile:master Mar 5, 2021
@Mugurell Mugurell deleted the openFlipboardIntents branch March 5, 2021 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:do-not-land pr:needs-ac-bump PR that needs a AC bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants