Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Firefox doesn't response from intent category CATEGORY_APP_BROWSER #16780

Closed
ilPikachu opened this issue Nov 30, 2020 · 2 comments
Closed

[Bug] Firefox doesn't response from intent category CATEGORY_APP_BROWSER #16780

ilPikachu opened this issue Nov 30, 2020 · 2 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:AndroidIntegration S3 Blocks non-critical functionality and a work around exists

Comments

@ilPikachu
Copy link

ilPikachu commented Nov 30, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

In certain situations, developers need to send an intent to be opened in browsers only instead of using ACTION_VIEW. This is done by using CATEGORY_APP_BROWSER (API Doc) with makeMainSelectorActivity (API Doc)

Currently, Chrome, Opera, Edge, and Brave handle this category.

This can be reproduced using the code blow:

fun startBrowserIntent(uri: Uri) {
        val intent = Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER)
        intent.data = uri

        startActivity(intent)
}

Expected behavior

After sending the intent, we should expect firefox to be in the list of Browser that handles CATEGORY_APP_BROWSER, but it does not.
test
test

Actual behavior

Screen Shot 2020-11-30 at 1 54 40 AM

### Device information
  • Android device: Pixel 2 XL
  • Fenix version: Firefox version 83.1.0

┆Issue is synchronized with this Jira Task
@ilPikachu ilPikachu added the 🐞 bug Crashes, Something isn't working, .. label Nov 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Nov 30, 2020
ilPikachu added a commit to ilPikachu/fenix that referenced this issue Nov 30, 2020
@ilPikachu
Feat: add AppBrowserIntentProcessor to handle category APP_BROWSER in…
050b429 
… the HomeAcitivity.

AppBrowserIntentProcessor coverts the intent action to ACTION_VIEW then utlizes TabIntentProcessor for processing.

CloneFIlter was used when converting to ViewIntent because we don't want to change the origional intent as it will be used for analytics tracking.

Closes mozilla-mobile#16780
@ilPikachu ilPikachu mentioned this issue Nov 30, 2020
Closed
3 tasks
ilPikachu added a commit to ilPikachu/fenix that referenced this issue Nov 30, 2020
@ilPikachu
Feat: add AppBrowserIntentProcessor to handle category APP_BROWSER in…
4a4fa53 
… the HomeAcitivity. Supports normal and private tabs

AppBrowserIntentProcessor coverts the intent action to ACTION_VIEW then utlizes TabIntentProcessor for processing.

CloneFIlter was used when converting to ViewIntent because we don't want to change the origional intent as it will be used for analytics tracking.

Closes mozilla-mobile#16780
ilPikachu added a commit to ilPikachu/fenix that referenced this issue Dec 1, 2020
@ilPikachu
Feat: add AppBrowserIntentProcessor to handle category APP_BROWSER in…
f9dba4b 
… the HomeAcitivity. Supports normal and private tabs

AppBrowserIntentProcessor coverts the intent action to ACTION_VIEW then utlizes TabIntentProcessor for processing.

CloneFIlter was used when converting to ViewIntent because we don't want to change the origional intent as it will be used for analytics tracking.

Closes mozilla-mobile#16780
ilPikachu added a commit to ilPikachu/fenix that referenced this issue Dec 1, 2020
@ilPikachu
Feat: add AppBrowserIntentProcessor to handle category APP_BROWSER in…
fcc7810 
… the HomeAcitivity. Supports normal and private tabs

AppBrowserIntentProcessor coverts the intent action to ACTION_VIEW then utlizes TabIntentProcessor for processing.

CloneFIlter was used when converting to ViewIntent because we don't want to change the origional intent as it will be used for analytics tracking.

Closes mozilla-mobile#16780
@ilPikachu ilPikachu changed the title [Bug] Firefox does not response from implicit intent that has category CATEGORY_APP_BROWSER [Bug] Firefox doesn't response from intent category CATEGORY_APP_BROWSER Dec 1, 2020
@kbrosnan kbrosnan added Feature:AndroidIntegration S3 Blocks non-critical functionality and a work around exists and removed needs:triage Issue needs triage labels Dec 1, 2020
@ilPikachu
Copy link
Author

ilPikachu commented Mar 8, 2021 •
edited
Loading

Support opening links from ACTION_MAIN Intents mozilla-mobile/android-components#9805
android-components PR: mozilla-mobile/android-components#9811
fenix PR: #18234

@Mugurell
Copy link
Contributor

Mugurell commented Mar 9, 2021

This was verified as fixed in #17963.
Closing.

@Mugurell Mugurell closed this as completed Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:AndroidIntegration S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #16780: Enable Firefox to handle intent category CATEGORY_APP_BROWSER ilPikachu/fenix
3 participants
@kbrosnan @Mugurell @ilPikachu