Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6070 Adds telemetry for enabling search suggestions in private #6746

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Nov 22, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare
Copy link
Contributor Author

mcarare commented Nov 22, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users choose to enable receiving search suggestions in private sessions.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • We want to know how users perceive search suggestions as regarding private browsing. This will help us choose the default setting for search suggestions in private - enabled or disabled.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • No current alternative methods.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this, this is a new feature.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #6746 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6746      +/-   ##
============================================
- Coverage     17.32%   17.32%   -0.01%     
  Complexity      390      390              
============================================
  Files           281      281              
  Lines         11207    11212       +5     
  Branches       1544     1545       +1     
============================================
  Hits           1942     1942              
- Misses         9114     9119       +5     
  Partials        151      151
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 7.49% <0%> (-0.05%) 3 <0> (ø)
...va/org/mozilla/fenix/components/metrics/Metrics.kt 20.08% <0%> (-0.17%) 0 <0> (ø)
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16aedb...b8b080b. Read the comment docs.

@mcarare mcarare force-pushed the 6070t branch 3 times, most recently from 52c1bda to c532434 Compare November 22, 2019 13:05
@mcarare mcarare changed the title For #6070 Adds telemetry for enabling search suggestions in private [WIP] For #6070 Adds telemetry for enabling search suggestions in private Nov 22, 2019
@mcarare mcarare added the needs:data-review PR is awaiting a data review label Nov 22, 2019
@mcarare mcarare requested a review from boek November 27, 2019 08:53
@mcarare mcarare force-pushed the 6070t branch 2 times, most recently from ce211e9 to d18aab3 Compare November 27, 2019 14:09
app/metrics.yaml Show resolved Hide resolved
app/metrics.yaml Show resolved Hide resolved
@boek
Copy link
Contributor

boek commented Nov 27, 2019

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, under data controls

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    Type 2, Type 1

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    Yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in at expiry

  9. Does the data collection use a third-party collection tool?
    No

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just fix the bad merge 👍

@boek
Copy link
Contributor

boek commented Nov 27, 2019

Also looks like tests are failing?

@mcarare mcarare force-pushed the 6070t branch 3 times, most recently from 1521ae2 to e29af1d Compare November 28, 2019 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants