Closes #338, #228: Improvements to x-axis formatting #365

emtwo · 2018-04-11T11:52:26Z

No description provided.

(incorporates: show data source type when no doc link present (re #46))

Still can not use unpublished queries on dashboards.

addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox

but don’t name a table abcdefghijklmnop.

I tried to make `JSON.stringify(this.visualization.options.columnMapping)` a variable to avoid repeating it, but if I make it a `let` the linter throws an error and if I make it a `const` then it doesn’t change with the UI and the logic doesn’t work. :( updated based on PR comments

)

Makes the _v of the schema browser toggle into a configurable string per data source. It is not required and if it is not filled in the toggle will not appear in the schema browser.

jezdez · 2018-04-26T15:16:58Z

r+

@emtwo Would you mind opening a PR upstream with this?

emtwo · 2018-04-27T20:33:38Z

@jezdez thanks. Do we want to merge this here and also open the PR upstream? Or just open it upstream and wait for it merge there first?

arikfr · 2018-04-29T07:16:40Z

I've recently found out that Plotly has an option to auto detect the axis type:

type ( enumerated : "-" | "linear" | "log" | "date" | "category" )
default: "-"
Sets the axis type. By default, plotly attempts to determined the axis type by looking into the data of the traces that referenced the axis in question.

https://plot.ly/javascript/reference/#layout-scene-xaxis-type

Have you tried this instead?

…etime.

emtwo · 2018-05-07T17:58:34Z

Thanks @arikfr! That seems to work and is a nicer and more concise alternative.

Here are a couple of queries I used to test:

For testing YYYYMMDD formatting and having it automatically be detected:

WITH sample as (
    select '20171001' as x, 'US' as type, 574047 as foo union
    select '20171002' as x, 'US' as type, 574047 as foo union
    select '20171003' as x, 'US' as type, 574047 as foo union
    select '20171004' as x, 'US' as type, 574047 as foo union
    select '20171005' as x, 'US' as type, 574047 as foo union
    select '20171006' as x, 'US' as type, 574047 as foo union
    select '20171007' as x, 'US' as type, 574047 as foo union
    select '20171008' as x, 'US' as type, 574047 as foo union
    select '20171009' as x, 'US' as type, 574047 as foo union
    select '20171010' as x, 'US' as type, 574047 as foo union
    select '20171011' as x, 'US' as type, 574047 as foo union
    select '20171012' as x, 'US' as type, 574047 as foo union
    select '20171013' as x, 'US' as type, 574047 as foo union
    select '20171014' as x, 'US' as type, 574047 as foo union
    select '20171015' as x, 'US' as type, 574047 as foo union
    select '20171016' as x, 'US' as type, 574047 as foo union
    select '20171017' as x, 'US' as type, 574047 as foo union
    select '20171018' as x, 'US' as type, 574047 as foo union
    select '20171019' as x, 'US' as type, 574047 as foo union
    select '20171020' as x, 'US' as type, 574047 as foo union
    select '20171021' as x, 'US' as type, 574047 as foo union
    select '20171022' as x, 'US' as type, 8215767 as foo union
    select '20171023' as x, 'US' as type, 574047 as foo union
    select '20171024' as x, 'US' as type, 574047 as foo union
    select '20171025' as x, 'US' as type, 574047 as foo union
    select '20171026' as x, 'US' as type, 574047 as foo union
    select '20171027' as x, 'US' as type, 574047 as foo union
    select '20171028' as x, 'US' as type, 8215767 as foo union
    select '20171029' as x, 'US' as type, 574047 as foo union
    select '20171030' as x, 'US' as type, 8215767 as foo)
select * from sample

For testing another (category) automatic x-axis type detection. Using a as x axis and b and/or c as y axis:

WITH sample AS
    (select 'a' as a, 121370 as b, 21.58 as c union
     select 'b' as a, 121170 as b, 11.53 as c union
     select 'c' as a, 121170 as b, 22.58 as c union
     select 'd' as a, 121170 as b, 41.58 as c)
select a, b, c from sample

arikfr · 2018-05-08T06:05:07Z

client/app/visualizations/chart/index.js

@@ -306,7 +306,7 @@ export default function init(ngModule) {
      sortX: true,
      legend: { enabled: true },
      yAxis: [{ type: 'linear' }, { type: 'linear', opposite: true }],
-      xAxis: { type: 'datetime', labels: { enabled: true } },
+      xAxis: { type: '-', labels: { enabled: true } },


You need to add this option to the xAxisScales array (and probably change it to have labels for each one, because currently we use the value itself, which won't work for -).

Okay that makes sense, @emtwo could take another look at this?

arikfr · 2018-05-08T06:05:56Z

👍
feel free to push this upstream as well :)

jezdez · 2018-05-09T13:26:42Z

@emtwo Let's merge this here first and then open an upstream PR at the same time as well. I'm not sure how quick we can expect merging upstream into our master.

emtwo · 2018-05-28T20:10:01Z

Just to follow up on this, there is a PR upstream that is currently under review with some comments recently addressed: getredash#2542

I didn't want to merge this PR here if it was going to change during the review process upstream, so I've left it open.

jezdez · 2018-06-19T13:18:31Z

@emtwo The PR getredash#2542 has been merged upstream, is there work needed here to extend it in our fork with functionality that wasn't accepted?

emtwo · 2018-06-20T15:28:12Z

@jezdez My suggested portion of the patch here: 7fb937d to resolve #338 was not accepted because the solution would do a regex match on large numbers, not just dates.

A couple of good suggestions are here: getredash#2542 (comment)

Though, in my opinion, it may be best/easiest to just stick with the first suggestion there, which is what we're already doing or have the jobs that generate/process the data making it into Athena to convert YYYYMMDD to YYYY-MM-DD.

I'm going to close this PR and #228 as it's being handled upstream.

jezdez · 2018-06-20T15:30:37Z

@emtwo Excellent, I fully agree. Thanks for your patience getting this upstreamed!

Allen Short and others added 30 commits March 5, 2018 22:34

In docker-entrypoint ensure tables exist

6100335

upgrade node and npm in dockerfile

018211b

Update circle.yml for our workflow

6d530c6

add pyup config document

4f395c3

Pin PyAthena dependency to 1.2.0.

29b1b99

Switch to PyMySQL for MySQL 5.7 support

357a8d4

upgrade to Celery 4.1.0

de4a5a1

Documentation links for data sources (re #6)

75228b2

(incorporates: show data source type when no doc link present (re #46))

Don't execute query when changing data sources (fixes #29)

e6720e0

Retry fetching query result on failure (fixes #36)

b4a8d5c

Use saved values for parameters in scheduled queries (re #43)

a7b4f46

delay schema filtering to improve responsiveness (fixes #45)

c5c9f14

Add schedule_until field to queries, to allow expiry (re #15)

a8ff8f4

add compare query version support (re #7)

2a7c354

accommodate '/' in dashboard tags (re #48)

be89d48

reject non-list dashboard layouts (re #25)

13c37cd

Reject empty names for dashboards (re #76)

d5304fe

allow unpublished queries to be used as alerts (re #97)

19343fb

Still can not use unpublished queries on dashboards.

dashboard textbox edit close fix (re #111)

8c62d24

addresses issue Madalin found that allows a click off the dialog box to close it without resetting the textbox

works for filtering _v literally (re #31)

04b433f

but don’t name a table abcdefghijklmnop.

Expose data source version info in UI (re #89)

4a5f5f8

adding activedata query_runner (re #83)

0d329d2

Re-prompt for login if an unauthorized Google account is used (fixes #79

5a22ec5

)

add toggle_table_string (re #130)

55a3e90

Makes the _v of the schema browser toggle into a configurable string per data source. It is not required and if it is not filled in the toggle will not appear in the schema browser.

add column type info to query runners (re #152, #23)

ce9565f

make the enter button submit the form (re #172)

82373ce

add hideParameters param (re #163)

de46def

add ability to add query to dashboard from query page (re #154)

d5a27be

Add last_active_at column to users page (re #155)

5a66ed0

emtwo force-pushed the emtwo/xaxis branch 2 times, most recently from 6fe90ee to 2cda756 Compare April 11, 2018 20:40

Marina Samuel added 2 commits April 11, 2018 16:54

Closes #359: Truncate x-axis by default.

eb1b3cb

Closes #374: Truncating x-axis should be done to ticktext not x values.

c151935

Marina Samuel and others added 4 commits May 2, 2018 16:16

Closes #387: Only truncate 'category' type labels.

7a2a3f2

Pad series text to be same length as x axis (re #391) (#392)

fc5437f

Closes #368: Wrap Autocomplete and checkbox in span and pad.

d7e413e

Closes #338: Allow dates formatted as YYYYMMDD to be displayed as dat…

7fb937d

…etime.

emtwo force-pushed the emtwo/xaxis branch from 2cda756 to 03f482c Compare May 7, 2018 17:18

arikfr reviewed May 8, 2018

View reviewed changes

emtwo force-pushed the emtwo/xaxis branch from 03f482c to 6188125 Compare May 16, 2018 14:47

Closes #228: Use Plotly's default xaxis type instead of datetime.

6806277

emtwo force-pushed the emtwo/xaxis branch from 6188125 to 6806277 Compare May 16, 2018 15:33

emtwo force-pushed the master branch from 3cf4c0f to b553699 Compare May 31, 2018 16:01

jezdez added the merge upstream label Jun 19, 2018

emtwo closed this Jun 20, 2018

jezdez deleted the emtwo/xaxis branch February 25, 2019 11:23

MaxMood96 mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities MaxMood96/redash#62

Open

MaxMood96 mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities MaxMood96/redash#89

Open

MaxMood96 mentioned this pull request Nov 14, 2023

[Snyk] Security upgrade copy-webpack-plugin from 4.6.0 to 5.0.5 MaxMood96/redash#127

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closes #338, #228: Improvements to x-axis formatting #365

Closes #338, #228: Improvements to x-axis formatting #365

emtwo commented Apr 11, 2018

jezdez commented Apr 26, 2018

emtwo commented Apr 27, 2018

arikfr commented Apr 29, 2018

emtwo commented May 7, 2018

arikfr May 8, 2018

jezdez May 9, 2018

arikfr commented May 8, 2018

jezdez commented May 9, 2018

emtwo commented May 28, 2018

jezdez commented Jun 19, 2018

emtwo commented Jun 20, 2018

jezdez commented Jun 20, 2018

Closes #338, #228: Improvements to x-axis formatting #365

Closes #338, #228: Improvements to x-axis formatting #365

Conversation

emtwo commented Apr 11, 2018

jezdez commented Apr 26, 2018

emtwo commented Apr 27, 2018

arikfr commented Apr 29, 2018

emtwo commented May 7, 2018

arikfr May 8, 2018

Choose a reason for hiding this comment

jezdez May 9, 2018

Choose a reason for hiding this comment

arikfr commented May 8, 2018

jezdez commented May 9, 2018

emtwo commented May 28, 2018

jezdez commented Jun 19, 2018

emtwo commented Jun 20, 2018

jezdez commented Jun 20, 2018