Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZExporter: Add support for interleaved data. #22633

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 4, 2021

Related issue: #22609 (comment)

Description

The exporter now supports interleaved data by using the dedicated BufferAttribute interface.

@mrdoob mrdoob added this to the r134 milestone Oct 4, 2021
@mrdoob mrdoob merged commit 6089e18 into mrdoob:dev Oct 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 4, 2021

Thanks!

@hybridherbst
Copy link
Contributor

@Mugen87 do you think each exporter should implement this separately, or would there be a good place to move common exporter functionality (like deinterleaving data, denormalizing, making textures readable, ...)? Thanks!

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 3, 2022

Supporting interleaved buffer data definitions happens automatically when the dedicated interface of BufferAttribute is used. The goal of the PR was to ensure that this is the case for USDZExporter.

The other features you have mentioned should ideally not implemented per exporter. As a first step, there is #22874 which tries to integrate (de)normalization in BufferAttribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants