Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make java an MSM installation dependency? #295

Closed
marcuswhybrow opened this issue Jul 20, 2015 · 3 comments
Closed

Make java an MSM installation dependency? #295

marcuswhybrow opened this issue Jul 20, 2015 · 3 comments
Labels

Comments

@marcuswhybrow
Copy link

PR #236 added sudo yum install java to the install_dependencies stage of installers/redhat.sh. We don't require Java be installed in installers/arch.sh or installers/debian.sh.

Should Java be consistently required across all distros? Java is not integral to MSM's logic. Java just happens to be used the "invocation" defined in MSM's settings. In theory this invocation command could be anything; although we all know it's going to use Java.

Thoughts?

@renderorange
Copy link
Contributor

Should Java be consistent[...] across all distros? I think definitely yes. If we removed Java from the install requirements for redhat, it would be the easiest path to being consistent. Although ultimately, the admin of the server will need to install java, else invocation is going to fail.

I guess the question is, should MSM take the responsibility of installing Java for them? One issue in assuming installation would then be, which Java? Oracle's version isn't available by default through Ubuntu's repos via apt-get, which Mojang themselves recommend using on their installation guide. If we assume installation, it would be for OpenJDK. Oracle's installation also requires accepting their EULA, which shouldn't be automated, IMO.

Should Java be consistently required across all distros? Personally, I don't think so. However, maybe having that be a part of the installation process, a (yes|no) question, would you like to install Java (OpenJDK), perhaps? This would give the admin a means to decide, do I want to install Oracle's or OpenJDK, do I already have a version installed already, etc?

@endofcake
Copy link
Contributor

@renderorange , I think it'd make sense to:

  • check if java is available,
  • if not, notify the admin and suggest to install the default version (which will be OpenJDK, I assume).

If anyone needs to use Oracle's Java, they can do this manually. It used to be a pretty involved process as far as I can remember, luckily WebUpd8 team's PPAs simplify this greatly now (for Ubuntu at least).

Touratica added a commit to Touratica/msm that referenced this issue Jul 24, 2022
The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above.

Fixes: Make java an MSM installation dependency? msmhq#295
Touratica added a commit to Touratica/msm that referenced this issue Jul 24, 2022
The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above.

Fixes: Make java an MSM installation dependency? msmhq#295
Touratica added a commit to Touratica/msm that referenced this issue Jul 25, 2022
…do and wget dependencies (#1)

* Set dependency installation as non-interactive

Fixes: apt waits for user input when installing dependencies msmhq#439

* Add sudo and wget as dependencies

Fixes: Installer assumes system has sudo and wget installed msmhq#440

* Add openjdk-17-jre-headless as dependency

The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above.

Fixes: Make java an MSM installation dependency? msmhq#295

* Add software-properties-common as dependency

The Debian script now installs software-properties-common if not installed, so it can use add-apt-repository.

Fixes: Installer assumes software-properties-common is installed on debian system msmhq#441

* Fix broken whitespace
@endofcake
Copy link
Contributor

Fix merged in #442 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants