Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer assumes system has sudo and wget installed #440

Closed
Touratica opened this issue Jul 24, 2022 · 1 comment
Closed

Installer assumes system has sudo and wget installed #440

Touratica opened this issue Jul 24, 2022 · 1 comment

Comments

@Touratica
Copy link
Contributor

The installer assumes the system has sudo and wget already installed. If not, the script will just error out. I think it should install those as dependencies.
Touratica added a commit to Touratica/msm that referenced this issue Jul 24, 2022
@Touratica
Add sudo and wget as dependencies
bbd966c 
Fixes: Installer assumes system has sudo and wget installed msmhq#440
Touratica added a commit to Touratica/msm that referenced this issue Jul 24, 2022
@Touratica
Add sudo and wget as dependencies
f9d55ab 
Fixes: Installer assumes system has sudo and wget installed msmhq#440
@Touratica Touratica mentioned this issue Jul 25, 2022
Merged
Touratica added a commit to Touratica/msm that referenced this issue Jul 25, 2022
@Touratica
Fix non-interactive install, and java, software-properties-common, su…
52f26a6 
…do and wget dependencies (#1)

* Set dependency installation as non-interactive

Fixes: apt waits for user input when installing dependencies msmhq#439

* Add sudo and wget as dependencies

Fixes: Installer assumes system has sudo and wget installed msmhq#440

* Add openjdk-17-jre-headless as dependency

The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above.

Fixes: Make java an MSM installation dependency? msmhq#295

* Add software-properties-common as dependency

The Debian script now installs software-properties-common if not installed, so it can use add-apt-repository.

Fixes: Installer assumes software-properties-common is installed on debian system msmhq#441

* Fix broken whitespace
@Touratica Touratica mentioned this issue Jul 25, 2022
Merged
@endofcake
Copy link
Contributor

Fix merged in #442 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endofcake @Touratica