Fix non-interactive install, and java, software-properties-common, sudo and wget dependencies #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do and wget dependencies (#1) * Set dependency installation as non-interactive Fixes: apt waits for user input when installing dependencies msmhq#439 * Add sudo and wget as dependencies Fixes: Installer assumes system has sudo and wget installed msmhq#440 * Add openjdk-17-jre-headless as dependency The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above. Fixes: Make java an MSM installation dependency? msmhq#295 * Add software-properties-common as dependency The Debian script now installs software-properties-common if not installed, so it can use add-apt-repository. Fixes: Installer assumes software-properties-common is installed on debian system msmhq#441 * Fix broken whitespace
|
Thank you for fixing these issues @Touratica . |
This was referenced Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: apt waits for user input when installing dependencies #439
Fixes: Installer assumes system has sudo and wget installed #440
The script will install openjdk-17-jre-headless if java isn't installed already. The choice for version 17 was motivated by the fact it is the latest LTS version and also that it is required for running Minecraft 1.18 and above.
Fixes: Make java an MSM installation dependency? #295
The Debian script now installs software-properties-common if not installed, so it can use add-apt-repository.
Fixes: Installer assumes software-properties-common is installed on debian system #441