Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against process termination code #185

Closed
rakaramos opened this issue Oct 9, 2020 · 0 comments · Fixed by #190
Closed

Guard against process termination code #185

rakaramos opened this issue Oct 9, 2020 · 0 comments · Fixed by #190
Assignees
@rakaramos
Labels
chore Work to reduce technical debt and improve the health of Muter's codebase, release process, and DX configuration Work that has to do with how you can configure Muter ease-of-use Work that's intended to improve the ease of using Muter

Comments

@rakaramos
Copy link
Member

As of today muter optimistically assumes that a test process always ends with success

muter/Sources/muterCore/MutationTesting/MutationTestingIODelegate.swift

Line 30 in dc53a9c

testProcessFileHandle.closeFile()

We should probably guard against exit codes, before diving into output parsing.
This will help our users to figure out configuration issues.
@rakaramos rakaramos added chore Work to reduce technical debt and improve the health of Muter's codebase, release process, and DX ease-of-use Work that's intended to improve the ease of using Muter configuration Work that has to do with how you can configure Muter labels Oct 9, 2020
@rakaramos rakaramos self-assigned this Oct 11, 2020
@ZevEisenberg ZevEisenberg mentioned this issue Oct 23, 2020
Closed
@ZevEisenberg ZevEisenberg mentioned this issue Nov 2, 2020
Merged
rakaramos added a commit that referenced this issue Nov 5, 2020
@rakaramos
Merge pull request #190 from muter-mutation-testing/bugfix/zeveisenbe…
b4e128d 
…rg/185-189-process-termination-code

#185 #189 process termination code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakaramos rakaramos

Labels
chore Work to reduce technical debt and improve the health of Muter's codebase, release process, and DX configuration Work that has to do with how you can configure Muter ease-of-use Work that's intended to improve the ease of using Muter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#185 #189 process termination code muter-mutation-testing/muter
1 participant
@rakaramos