Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muter incorrectly fails when successful test contains "fatal error" text #189

Closed
ZevEisenberg opened this issue Oct 23, 2020 · 0 comments · Fixed by #190
Closed

Muter incorrectly fails when successful test contains "fatal error" text #189

ZevEisenberg opened this issue Oct 23, 2020 · 0 comments · Fixed by #190
Assignees
Labels
bug Something isn't working

Comments

@ZevEisenberg
Copy link
Collaborator

TestSuiteOutcome.swift:57 checks to see if the entire test log contains the text "fatal error". But sometimes, this is valid in a test log. Instead, we should look at the process.terminationReason at MutationTestingIODelegate.swift:28. Related to #185.

One way to reproduce this is to have a test suite that uses assertionFailure("foo") in a test. The failure may not halt the process, but will still print a message.

We're still looking into why an assertionFailure would put Fatal Error in the log but not halt the tests; will post here if we find out.

A nice way to test this could be to mock Process so we can return arbitrary error codes without having to build a whole sample project to reproduce this issue.

@ZevEisenberg ZevEisenberg self-assigned this Oct 23, 2020
@ZevEisenberg ZevEisenberg added the bug Something isn't working label Oct 23, 2020
rakaramos added a commit that referenced this issue Nov 5, 2020
…rg/185-189-process-termination-code

#185 #189 process termination code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant