#185 #189 process termination code #190
Conversation
| @@ -9,55 +9,60 @@ class TestSuiteResultParsingSpec: QuickSpec { | |||
| context("when a test log doesn't contain a failure, runtime error, or build error") { | |||
| it("returns a passed test result") { | |||
| var contents = loadLogFile(named: "testRunWithoutFailures_withTestSucceededFooter.log") | |||
| expect(TestSuiteOutcome.from(testLog: contents)).to(equal(.passed)) | |||
| expect(TestSuiteOutcome.from(testLog: contents, terminationStatus: 0)).to(equal(.passed)) | |||
There was a problem hiding this comment.
I used 0 for everything except the one case I cared about testing. We should probably think about whether any of the rest of these tests need to change or be expanded.
There was a problem hiding this comment.
I agree (left a comment above b4 reading it, sorry 😄 )
|
|
||
| if logContainsRuntimeError(testLog) { | ||
| if !terminationStatusIsSuccess(terminationStatus) { |
There was a problem hiding this comment.
I think regression tests are still passing, right? Because I think xcodebuild returns 65 when tests fails.
I've find this unofficial list of exit codes... if can also improve it later
| @@ -23,16 +23,16 @@ struct MutationTestingDelegate: MutationTestingIODelegate { | |||
| savingResultsIntoFileNamed fileName: String) -> (outcome: TestSuiteOutcome, testLog: String) { | |||
| do { | |||
| let (testProcessFileHandle, testLogUrl) = try fileHandle(for: fileName) | |||
| defer { testProcessFileHandle.closeFile() } | |||
There was a problem hiding this comment.
Is it the same behaviour as we had before? It seems now that the file handle is closed after we attempt to read it.
There was a problem hiding this comment.
defer happens right before the scope closes. It should be the same behavior as before, but now it'll still happen if we add an early return. I was originally going to use a guard in an earlier version of this PR. I ended up not doing it, but I still like using defer for open/close patterns.
rakaramos
deleted the
bugfix/zeveisenberg/185-189-process-termination-code
branch
Fixes #185
Fixes #189
Look at the process termination code instead of just parsing the logs. Correctly handles a case where the logs might mention the string "fatal error" even when the tests are passing.