Use correct separator in keywords.txt #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you insist on having hyperlinks in the commit message, I suggest you use a URL-shorterner for them. |
The Arduino IDE currently requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.
|
Commit line length issue that was breaking the gitler test fixed. I recommend adding the commit message requirements to CONTRIBUTING.md. |
|
Good point. @henrikekblad will you look into that? The code contribution guidelines are also available here. |
mfalkvidd
added a commit
to mfalkvidd/MySensors
that referenced
this pull request
Dec 8, 2017
As mentioned by per1234 in mysensors#1008 we should make it easier to find the full code contribution guidelines. Since we have multiple git repos, we don't want to duplicate the guidelines in each repo. Instead, we link to the canonical source on mysensors.org.
fallberg
pushed a commit
that referenced
this pull request
Dec 9, 2017
As mentioned by per1234 in #1008 we should make it easier to find the full code contribution guidelines. Since we have multiple git repos, we don't want to duplicate the guidelines in each repo. Instead, we link to the canonical source on mysensors.org.
mfalkvidd
added a commit
to mfalkvidd/MySensors
that referenced
this pull request
Feb 18, 2018
…-inclusionfix * origin/development: (31 commits) Development version 2.2.1-alpha (mysensors#1043) MySensors 2.2.0 release Update README.md for upcoming release (mysensors#994) Add MY_INCLUSION_LED_PIN (mysensors#1030) Relax Gitler on commit headline length (mysensors#1031) Correct misspells (mysensors#1028) SignalReport disabled by default (mysensors#1027) Linux/SerialPort: Log success message (mysensors#1021) Linux: Fix null ptr exception (mysensors#1025) Update doxygen (mysensors#1024) Doxygenize MyGatewayTransport (mysensors#1023) RFM69: Fix compiler warnings (mysensors#1020) Add MY_RS485_SOH_COUNT option (mysensors#1014) Update reference to Code Contribution Guidelines (mysensors#1011) MySensors 2.2.0-rc.2 (mysensors#1000) Use correct separator in keywords.txt (mysensors#1008) Fix FOTA updates with smart sleep (mysensors#999) Harmonize debug outputs (mysensors#1002) Add MY_DEBUGDEVICE to redirect debug output (mysensors#1006) MySensors 2.1.1 release (mysensors#752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arduino IDE currently requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.
Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords