SignalReport disabled by default #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekka007
force-pushed
the
SignalReport
branch
2 times, most recently
from
9b45754 to
460f293
Compare
mfalkvidd
reviewed
Jan 10, 2018
MyConfig.h
Outdated
| #endif | ||
| * @def MY_SIGNAL_REPORT_ENABLED | ||
| * @brief Enables signal report functionality. | ||
| * @note Enabled by default. This feature adds ~1kB code to the sketch. |
There was a problem hiding this comment.
Is signal report enabled by default or not? Commit message says not enabled, doxygen comment says enabled.
There was a problem hiding this comment.
good catch - will update the PR. Thanks
tekka007
force-pushed
the
SignalReport
branch
from
460f293 to
a98be15
Compare
mfalkvidd
added a commit
to mfalkvidd/MySensors
that referenced
this pull request
Feb 18, 2018
…-inclusionfix * origin/development: (31 commits) Development version 2.2.1-alpha (mysensors#1043) MySensors 2.2.0 release Update README.md for upcoming release (mysensors#994) Add MY_INCLUSION_LED_PIN (mysensors#1030) Relax Gitler on commit headline length (mysensors#1031) Correct misspells (mysensors#1028) SignalReport disabled by default (mysensors#1027) Linux/SerialPort: Log success message (mysensors#1021) Linux: Fix null ptr exception (mysensors#1025) Update doxygen (mysensors#1024) Doxygenize MyGatewayTransport (mysensors#1023) RFM69: Fix compiler warnings (mysensors#1020) Add MY_RS485_SOH_COUNT option (mysensors#1014) Update reference to Code Contribution Guidelines (mysensors#1011) MySensors 2.2.0-rc.2 (mysensors#1000) Use correct separator in keywords.txt (mysensors#1008) Fix FOTA updates with smart sleep (mysensors#999) Harmonize debug outputs (mysensors#1002) Add MY_DEBUGDEVICE to redirect debug output (mysensors#1006) MySensors 2.1.1 release (mysensors#752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves 1kB of flash - enable only if needed (
#define MY_SIGNAL_REPORT_ENABLED)