RFM69: Fix compiler warnings #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfalkvidd
reviewed
Dec 27, 2017
There was a problem hiding this comment.
Isn't the commit message misleading? From what I can see, changing = to == fixes faulty logic. The compiler warnings were good warnings, since the logic was faulty.
If this does fix compiler warnings, could the warnings be listed in the commit message so I can see what the warnings were?
mfalkvidd
added a commit
to mfalkvidd/MySensors
that referenced
this pull request
Feb 18, 2018
…-inclusionfix * origin/development: (31 commits) Development version 2.2.1-alpha (mysensors#1043) MySensors 2.2.0 release Update README.md for upcoming release (mysensors#994) Add MY_INCLUSION_LED_PIN (mysensors#1030) Relax Gitler on commit headline length (mysensors#1031) Correct misspells (mysensors#1028) SignalReport disabled by default (mysensors#1027) Linux/SerialPort: Log success message (mysensors#1021) Linux: Fix null ptr exception (mysensors#1025) Update doxygen (mysensors#1024) Doxygenize MyGatewayTransport (mysensors#1023) RFM69: Fix compiler warnings (mysensors#1020) Add MY_RS485_SOH_COUNT option (mysensors#1014) Update reference to Code Contribution Guidelines (mysensors#1011) MySensors 2.2.0-rc.2 (mysensors#1000) Use correct separator in keywords.txt (mysensors#1008) Fix FOTA updates with smart sleep (mysensors#999) Harmonize debug outputs (mysensors#1002) Add MY_DEBUGDEVICE to redirect debug output (mysensors#1006) MySensors 2.1.1 release (mysensors#752) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1019